Skip to content

Commit 755efa7

Browse files
dfa1claude
andcommitted
build(integration): aggregate parquet/csv coverage for Sonar
The coverage-profile report-aggregate promoted only core/reader/ writer/inspector to compile scope, so parquet and csv — dependency modules genuinely exercised by the integration tests — had their class directories invisible to jacoco:report-aggregate, dropping their cross-module coverage from Sonar. Promote them too. (Unit coverage of non-dependency modules reaches Sonar via their own per-module jacoco.xml, not this aggregate.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent e478a3a commit 755efa7

1 file changed

Lines changed: 17 additions & 4 deletions

File tree

integration/pom.xml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,13 @@
105105
<profiles>
106106
<profile>
107107
<id>coverage</id>
108-
<!-- When reporting coverage, promote key modules from test to compile scope so
109-
jacoco:report-aggregate can locate their class directories. The integration
110-
module is never published (maven.deploy.skip=true) so this has no downstream
111-
impact. -->
108+
<!-- When reporting coverage, promote every dependency module exercised by the
109+
integration tests from test to compile scope so jacoco:report-aggregate can
110+
locate their class directories — otherwise their cross-module integration
111+
coverage never reaches Sonar (parquet/csv were previously omitted). The
112+
integration module is never published (maven.deploy.skip=true) so this has no
113+
downstream impact. Unit coverage of non-dependency modules (cli, calcite,
114+
fbs-gen, …) reaches Sonar through their own per-module jacoco.xml, not here. -->
112115
<dependencies>
113116
<dependency>
114117
<groupId>io.github.dfa1.vortex</groupId>
@@ -130,6 +133,16 @@
130133
<artifactId>vortex-inspector</artifactId>
131134
<scope>compile</scope>
132135
</dependency>
136+
<dependency>
137+
<groupId>io.github.dfa1.vortex</groupId>
138+
<artifactId>vortex-parquet</artifactId>
139+
<scope>compile</scope>
140+
</dependency>
141+
<dependency>
142+
<groupId>io.github.dfa1.vortex</groupId>
143+
<artifactId>vortex-csv</artifactId>
144+
<scope>compile</scope>
145+
</dependency>
133146
</dependencies>
134147
<build>
135148
<plugins>

0 commit comments

Comments
 (0)