Skip to content

Commit 83dec66

Browse files
dfa1claude
andcommitted
docs(todo): update pluggability audit and encoding table for allowUnknown()
Note allowUnknown() as implemented under Encodings pluggability. Mark vortex.patched and vortex.variant rows (encoding table + fixture table) as passthrough-safe via allowUnknown() since no decoder or fixture exists. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 6d47319 commit 83dec66

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

TODO.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@
8383

8484
- [ ] **Audit runtime pluggability vs Rust impl** — maintainer (2026-06-04) flagged that Rust supports
8585
runtime registration for: Encodings, DTypes, Compute, Layouts. Java status:
86-
- Encodings: ✅ `ServiceLoader` + `EncodingRegistry.register()`
86+
- Encodings: ✅ `ServiceLoader` + `EncodingRegistry.register()`; ✅ `allowUnknown()` passthrough for unregistered encodings (mirrors `VortexSession::allow_unknown()`)
8787
- DTypes: ❌ sealed hierarchy — no user-extensible type. If a downstream consumer needs a custom
8888
logical type (e.g. UUID, IP address) they can't register one. Decide: keep sealed (simpler) or
8989
open via SPI mirroring `EncodingRegistry`.
@@ -130,8 +130,8 @@
130130
| `vortex.fixed_size_list` | `FixedSizeListEncoding` |||| one child: flat elements; no offsets |
131131
| `vortex.zstd` | `ZstdEncoding` |||| Primitive, Utf8, Binary (no dict, no nullable); uses airlift/aircompressor |
132132
| `vortex.masked` | `MaskedEncoding` |||| child[0]=payload (non-nullable), child[1]=validity Bool (optional); no S3 fixture in v0.72.0 |
133-
| `vortex.patched` |||| unknown | ID registered; no decoder yet; no S3 fixture in v0.72.0 |
134-
| `vortex.variant` |||| unknown | ID registered; no decoder yet; no S3 fixture in v0.72.0 |
133+
| `vortex.patched` |||| unknown | ID registered; no decoder yet; no S3 fixture in v0.72.0; passthrough via `allowUnknown()` |
134+
| `vortex.variant` |||| unknown | ID registered; no decoder yet; no S3 fixture in v0.72.0; passthrough via `allowUnknown()` |
135135

136136
### `vortex.zstd` known limitations
137137

@@ -257,8 +257,8 @@ post-decode + post-`vortex-arrow` bridge.
257257
| `clickbench_hits_5k.compact.vortex` || |
258258
| `clickbench_hits_5k.regular.vortex` || |
259259
| `masked.vortex` || no fixture in v0.72.0; `vortex.masked` ID registered |
260-
| `patched.vortex` || no fixture in v0.72.0; `vortex.patched` ID registered |
261-
| `variant.vortex` || no fixture in v0.72.0; `vortex.variant` ID registered |
260+
| `patched.vortex` || no fixture in v0.72.0; `vortex.patched` ID registered; passthrough via `allowUnknown()` |
261+
| `variant.vortex` || no fixture in v0.72.0; `vortex.variant` ID registered; passthrough via `allowUnknown()` |
262262

263263
**Score: 35/35**
264264

0 commit comments

Comments
 (0)