refactor: rename FbsInlineStruct -> FbsMemorySegment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: dfa1

CLAUDE.md

@@ -77,9 +77,9 @@ Regenerate after editing `.fbs`/`.proto` (both generators are in-house, no exter
 Both schema languages are compiled in-process to MemorySegment-native Java, with no
 `flatc`/`protoc` and no `com.google.flatbuffers`/`protobuf-java` runtime (ADR 0017):
 - **`.fbs` → `fbs-gen`** (`io.github.dfa1.vortex.fbsgen`): generates readers extending
-  `FbsTable` (vtable-based) or `FbsInlineStruct` (fixed-offset inline) and builders over
+  `FbsTable` (vtable-based) or `FbsMemorySegment` (fixed-offset inline) and builders over
   `FbsBuilder`, all in the same generated package `io.github.dfa1.vortex.core.fbs`. The
-  runtime base classes `FbsTable`/`FbsInlineStruct` are package-private (only generated
+  runtime base classes `FbsTable`/`FbsMemorySegment` are package-private (only generated
   readers extend them); `FbsBuilder` is public because the writer module assembles FlatBuffers
   with it. Schema names with a trailing `_` (e.g. `Struct_`) have the underscore stripped in
   the generated Java class name (`FbsStruct`) — the upstream uses `_` to avoid C++ conflicts,

core/src/main/java/io/github/dfa1/vortex/core/fbs/FbsBuffer.java

@@ -7,7 +7,7 @@
 
 /// Reader and builder for the `Buffer` FlatBuffers struct (inline, 8 bytes).
 @Generated("io.github.dfa1.vortex.fbsgen.CodeGen")
-public final class FbsBuffer extends FbsInlineStruct {
+public final class FbsBuffer extends FbsMemorySegment {
 
     /// Positions this reader at a struct.
     /// @param seg the buffer

…fa1/vortex/core/fbs/FbsInlineStruct.java …a1/vortex/core/fbs/FbsMemorySegment.javacore/src/main/java/io/github/dfa1/vortex/core/fbs/FbsInlineStruct.java renamed to core/src/main/java/io/github/dfa1/vortex/core/fbs/FbsMemorySegment.java core/src/main/java/io/github/dfa1/vortex/core/fbs/FbsInlineStruct.java renamed to core/src/main/java/io/github/dfa1/vortex/core/fbs/FbsMemorySegment.java

@@ -17,7 +17,7 @@
 /// directly at `position + fieldOffset`.
 ///
 /// Package-private: only the generated struct accessors in this package extend it.
-class FbsInlineStruct {
+class FbsMemorySegment {
 
     /// The backing buffer.
     protected MemorySegment seg;
@@ -26,7 +26,7 @@ class FbsInlineStruct {
     protected long pos;
 
     /// Creates an unpositioned cursor; call [#init(MemorySegment, long)] before use.
-    protected FbsInlineStruct() {
+    protected FbsMemorySegment() {
     }
 
     /// Positions this cursor at a struct.

core/src/main/java/io/github/dfa1/vortex/core/fbs/FbsSegmentSpec.java

@@ -7,7 +7,7 @@
 
 /// Reader and builder for the `SegmentSpec` FlatBuffers struct (inline, 16 bytes).
 @Generated("io.github.dfa1.vortex.fbsgen.CodeGen")
-public final class FbsSegmentSpec extends FbsInlineStruct {
+public final class FbsSegmentSpec extends FbsMemorySegment {
 
     /// Positions this reader at a struct.
     /// @param seg the buffer

fbs-gen/src/main/java/io/github/dfa1/vortex/fbsgen/CodeGen.java

@@ -11,7 +11,7 @@
 /// One `.java` file per declaration:
 /// - each `table` becomes a `final class extends FbsTable` with read accessors plus
 ///   `createX`/`startX`/`addX`/`endX`/`finishXBuffer` builders;
-/// - each `struct` becomes a `final class extends FbsInlineStruct` with inline-offset accessors
+/// - each `struct` becomes a `final class extends FbsMemorySegment` with inline-offset accessors
 ///   and an inline `createX` builder;
 /// - each `enum` becomes a constants holder over its underlying integer type;
 /// - each `union` becomes a discriminator-constants holder (NONE = 0, members from 1).
@@ -295,7 +295,7 @@ private String emitStruct(Ast.StructDecl struct) {
         sb.append("/// Reader and builder for the `").append(struct.name()).append("` FlatBuffers struct (inline, ")
                 .append(layout.size()).append(" bytes).\n");
         sb.append(GENERATED_ANNOTATION);
-        sb.append("public final class ").append(name).append(" extends FbsInlineStruct {\n\n");
+        sb.append("public final class ").append(name).append(" extends FbsMemorySegment {\n\n");
         sb.append("""
                     /// Positions this reader at a struct.
                     /// @param seg the buffer
@@ -723,7 +723,7 @@ private static VectorElem scalarVectorElem(Ast.Scalar scalar) {
     ///
     /// @param javaType   accessor return type
     /// @param readPrefix expression prefix (e.g. a widening cast), or empty
-    /// @param readMethod FbsTable/FbsInlineStruct reader method name
+    /// @param readMethod FbsTable/FbsMemorySegment reader method name
     /// @param readSuffix expression suffix (e.g. an unsigned mask or `!= 0`), or empty
     /// @param zero       default/absent value literal
     private record ScalarIo(String javaType, String readPrefix, String readMethod, String readSuffix, String zero) {

fbs-gen/src/test/java/io/github/dfa1/vortex/fbsgen/CodeGenTest.java

@@ -71,7 +71,7 @@ void emitsInlineOffsetsForStruct() throws IOException {
         String src = generateOne("FbsBuffer.java");
 
         // Then
-        assertThat(src).contains("extends FbsInlineStruct");
+        assertThat(src).contains("extends FbsMemorySegment");
         assertThat(src).contains("8 bytes");
         assertThat(src).contains("public int padding() {\n        return readShort(0) & 0xFFFF;");
         assertThat(src).contains("public int alignmentExponent() {\n        return readByte(2) & 0xFF;");

integration/src/test/java/io/github/dfa1/vortex/integration/RaincloudConformanceIntegrationTest.java

@@ -110,11 +110,14 @@ private static void reportUntriaged(Path vortex, Path parquet) {
         try {
             assertMatchesParquetOracle(vortex, parquet);
         } catch (TestAbortedException e) {
+            System.out.println("TRIAGE " + vortex + " => ABORTED " + e.getMessage());
             throw e; // oracle limitation, not a conformance outcome
         } catch (AssertionError | Exception e) {
+            System.out.println("TRIAGE " + vortex + " => FAILS " + e.getMessage());
             throw new TestAbortedException(
                     "untriaged slug fails — classify as gap:<issue> in expected-status.csv: " + e);
         }
+        System.out.println("TRIAGE " + vortex + " => OK");
         throw new TestAbortedException("untriaged slug passes — flip its matrix entry to ok");
     }