Commit ccd4767
committed
test: replace duplicated countRows(reader) helper with layout().rowCount()
Both ParquetImporterTest and ParquetImportIntegrationTest reimplemented
the same helper — a full scan decoding every chunk just to sum
rowCount(). VortexReader.layout().rowCount() already answers this
directly from the footer metadata, no scan needed (CsvExporter already
uses it this way for progress tracking).1 parent 41b7cc3 commit ccd4767
2 files changed
Lines changed: 4 additions & 21 deletions
File tree
- integration/src/test/java/io/github/dfa1/vortex/integration
- parquet/src/test/java/io/github/dfa1/vortex/parquet
Lines changed: 2 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | 41 | | |
50 | 42 | | |
51 | 43 | | |
| |||
106 | 98 | | |
107 | 99 | | |
108 | 100 | | |
109 | | - | |
| 101 | + | |
110 | 102 | | |
111 | 103 | | |
112 | 104 | | |
| |||
210 | 202 | | |
211 | 203 | | |
212 | 204 | | |
213 | | - | |
| 205 | + | |
214 | 206 | | |
215 | 207 | | |
216 | 208 | | |
| |||
Lines changed: 2 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | 26 | | |
28 | 27 | | |
29 | 28 | | |
| |||
198 | 197 | | |
199 | 198 | | |
200 | 199 | | |
201 | | - | |
| 200 | + | |
202 | 201 | | |
203 | 202 | | |
204 | 203 | | |
| |||
244 | 243 | | |
245 | 244 | | |
246 | 245 | | |
247 | | - | |
| 246 | + | |
248 | 247 | | |
249 | 248 | | |
250 | 249 | | |
| |||
290 | 289 | | |
291 | 290 | | |
292 | 291 | | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | 292 | | |
0 commit comments