fix: reject control characters in EncodingId and LayoutId

A control-char ID would write a file PostscriptParser crashes on.
Both Custom constructors now scan for ISO control characters,
mirroring ColumnName.violation().

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: dfa1

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- `EncodingId.Custom` and `LayoutId.Custom` now reject wire strings containing ISO control characters, mirroring `ColumnName`. A control-char id previously wrote a corrupt file that `PostscriptParser` crashes on at read time. (internal)
 - Parquet files with duplicate column names now compare correctly. The oracle header de-duplicates names with the Rust Vortex writer's algorithm (first occurrence unmodified, Nth repetition gets ` [N]` suffix) and all row access uses column index rather than name. ([#256](https://github.com/dfa1/vortex-java/issues/256))
 - Blank column names are now accepted on both the read and write paths. The Rust reference legitimately produces them (e.g. `uci-electricityloaddiagrams20112014` has one at field index 0). `ColumnName` now enforces a symmetric policy: non-null and free of control characters (`\n`, `\t`, U+0000, …); blank names such as `""` or `" "` pass through on both paths. ([#255](https://github.com/dfa1/vortex-java/issues/255))
 - `VarBinArray.DictMode` reads dict-value offsets in a ptype-uniform loop: the I32 fast path eliminates the per-row `switch(dictValOffPType)` that blocked C2 vectorization (introduced by #215). ([#243](https://github.com/dfa1/vortex-java/issues/243))

core/src/main/java/io/github/dfa1/vortex/core/model/EncodingId.java

@@ -140,20 +140,29 @@ public String toString() {
 
     /// A third-party encoding id whose wire string is not part of the [WellKnown] set.
     ///
-    /// @param id the wire string of this encoding id; must be non-blank and must not collide
-    ///           with a [WellKnown] wire string
+    /// @param id the wire string of this encoding id; must be non-blank, free of ISO control
+    ///           characters, and must not collide with a [WellKnown] wire string
     record Custom(String id) implements EncodingId {
 
-        /// Validates that `id` is a usable custom encoding id.
+        /// Validates that `id` is a usable custom encoding id. A control character would write a
+        /// file that [io.github.dfa1.vortex.core.error.VortexException]-raising parsers crash on,
+        /// so the same policy as [ColumnName#violation(String)] applies here.
         ///
         /// @param id the wire string of this encoding id
         /// @throws NullPointerException     if `id` is `null`
-        /// @throws IllegalArgumentException if `id` is blank or matches a [WellKnown] wire string
+        /// @throws IllegalArgumentException if `id` is blank, contains an ISO control character, or
+        ///                                  matches a [WellKnown] wire string
         public Custom {
             Objects.requireNonNull(id, "id");
             if (id.isBlank()) {
                 throw new IllegalArgumentException("encoding id must not be blank");
             }
+            for (int i = 0; i < id.length(); i++) {
+                if (Character.isISOControl(id.charAt(i))) {
+                    throw new IllegalArgumentException(
+                            "encoding id contains control character U+%04X".formatted((int) id.charAt(i)));
+                }
+            }
             WellKnown wellKnown = WellKnown.byId(id);
             if (wellKnown != null) {
                 throw new IllegalArgumentException(

core/src/main/java/io/github/dfa1/vortex/core/model/LayoutId.java

@@ -82,20 +82,29 @@ public String toString() {
 
     /// A third-party layout id whose wire string is not part of the [WellKnown] set.
     ///
-    /// @param id the wire string of this layout id; must be non-blank and must not collide
-    ///           with a [WellKnown] wire string
+    /// @param id the wire string of this layout id; must be non-blank, free of ISO control
+    ///           characters, and must not collide with a [WellKnown] wire string
     record Custom(String id) implements LayoutId {
 
-        /// Validates that `id` is a usable custom layout id.
+        /// Validates that `id` is a usable custom layout id. A control character would write a
+        /// file that [io.github.dfa1.vortex.core.error.VortexException]-raising parsers crash on,
+        /// so the same policy as [ColumnName#violation(String)] applies here.
         ///
         /// @param id the wire string of this layout id
         /// @throws NullPointerException     if `id` is `null`
-        /// @throws IllegalArgumentException if `id` is blank or matches a [WellKnown] wire string
+        /// @throws IllegalArgumentException if `id` is blank, contains an ISO control character, or
+        ///                                  matches a [WellKnown] wire string
         public Custom {
             Objects.requireNonNull(id, "id");
             if (id.isBlank()) {
                 throw new IllegalArgumentException("layout id must not be blank");
             }
+            for (int i = 0; i < id.length(); i++) {
+                if (Character.isISOControl(id.charAt(i))) {
+                    throw new IllegalArgumentException(
+                            "layout id contains control character U+%04X".formatted((int) id.charAt(i)));
+                }
+            }
             WellKnown wellKnown = WellKnown.byId(id);
             if (wellKnown != null) {
                 throw new IllegalArgumentException(

core/src/test/java/io/github/dfa1/vortex/core/model/EncodingIdTest.java

@@ -70,6 +70,15 @@ void construct_wellKnownId_throwsIllegalArgumentException() {
                     .isInstanceOf(IllegalArgumentException.class)
                     .hasMessageContaining("VORTEX_PRIMITIVE");
         }
+
+        @ParameterizedTest
+        @ValueSource(strings = {"a\nb", "tab\there"})
+        void custom_controlCharId_throwsIllegalArgumentException(String id) {
+            // Given / When / Then — a control char would write a file PostscriptParser crashes on,
+            // so Custom rejects it just as ColumnName does
+            assertThatThrownBy(() -> new EncodingId.Custom(id))
+                    .isInstanceOf(IllegalArgumentException.class);
+        }
     }
 
     @Nested

core/src/test/java/io/github/dfa1/vortex/core/model/LayoutIdTest.java

@@ -70,6 +70,15 @@ void construct_wellKnownId_throwsIllegalArgumentException() {
                     .isInstanceOf(IllegalArgumentException.class)
                     .hasMessageContaining("FLAT");
         }
+
+        @ParameterizedTest
+        @ValueSource(strings = {"a\nb", "tab\there"})
+        void custom_controlCharId_throwsIllegalArgumentException(String id) {
+            // Given / When / Then — a control char would write a file PostscriptParser crashes on,
+            // so Custom rejects it just as ColumnName does
+            assertThatThrownBy(() -> new LayoutId.Custom(id))
+                    .isInstanceOf(IllegalArgumentException.class);
+        }
     }
 
     @Nested