Skip to content

Commit fdbb352

Browse files
dfa1claude
andcommitted
refactor: drop redundant ServiceLoader constructors (S1186)
All 73 S1186 "empty method" hits were explicit public no-arg constructors on the codec classes (EncodingDecoder/EncodingEncoder impls and the extension singletons). They are redundant: a public class with no declared constructor already has an implicit public no-arg constructor, which is exactly what ServiceLoader needs — so the empty bodies are deleted rather than commented. Simplify-first: remove code, kill the smell at the root, no unkillable comment. EncodingTableFitnessTest (ServiceLoads every decoder/encoder) stays green, proving discovery is unaffected; full verify green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent d859db0 commit fdbb352

73 files changed

Lines changed: 0 additions & 337 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

reader/src/main/java/io/github/dfa1/vortex/reader/decode/AlpEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ public final class AlpEncodingDecoder implements EncodingDecoder {
2626
private static final float[] F10_F32 = {1e0f, 1e1f, 1e2f, 1e3f, 1e4f, 1e5f, 1e6f, 1e7f, 1e8f, 1e9f, 1e10f};
2727
private static final float[] IF10_F32 = {1e-0f, 1e-1f, 1e-2f, 1e-3f, 1e-4f, 1e-5f, 1e-6f, 1e-7f, 1e-8f, 1e-9f, 1e-10f};
2828

29-
/// Public no-arg constructor required by [java.util.ServiceLoader].
30-
public AlpEncodingDecoder() {
31-
}
32-
3329
@Override
3430
public EncodingId encodingId() {
3531
return EncodingId.VORTEX_ALP;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/AlpRdEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
/// Read-only decoder for `vortex.alprd`.
2222
public final class AlpRdEncodingDecoder implements EncodingDecoder {
2323

24-
/// Public no-arg constructor required by [java.util.ServiceLoader].
25-
public AlpRdEncodingDecoder() {
26-
}
27-
2824
@Override
2925
public EncodingId encodingId() {
3026
return EncodingId.VORTEX_ALPRD;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/BitpackedEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,6 @@
2121
public final class BitpackedEncodingDecoder implements EncodingDecoder {
2222
private static final int[] FL_ORDER = {0, 4, 2, 6, 1, 5, 3, 7};
2323

24-
/// Public no-arg constructor required by [java.util.ServiceLoader].
25-
public BitpackedEncodingDecoder() {
26-
}
27-
2824
@Override
2925
public EncodingId encodingId() {
3026
return EncodingId.FASTLANES_BITPACKED;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/BoolEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
/// Read-only decoder for bit-packed boolean arrays.
1010
public final class BoolEncodingDecoder implements EncodingDecoder {
1111

12-
/// Public no-arg constructor required by [java.util.ServiceLoader].
13-
public BoolEncodingDecoder() {
14-
}
15-
1612
@Override
1713
public EncodingId encodingId() {
1814
return EncodingId.VORTEX_BOOL;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/ByteBoolEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
/// bit-packed [BoolArray] layout used by `vortex.bool`.
1212
public final class ByteBoolEncodingDecoder implements EncodingDecoder {
1313

14-
/// Public no-arg constructor required by [java.util.ServiceLoader].
15-
public ByteBoolEncodingDecoder() {
16-
}
17-
1814
@Override
1915
public EncodingId encodingId() {
2016
return EncodingId.VORTEX_BYTEBOOL;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/ChunkedEncodingDecoder.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@
2323
/// Read-only decoder for `vortex.chunked`.
2424
public final class ChunkedEncodingDecoder implements EncodingDecoder {
2525

26-
27-
/// Public no-arg constructor required by [java.util.ServiceLoader].
28-
public ChunkedEncodingDecoder() {
29-
}
30-
3126
@Override
3227
public EncodingId encodingId() {
3328
return EncodingId.VORTEX_CHUNKED;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/ConstantEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@
2626
/// Read-only decoder for `vortex.constant`.
2727
public final class ConstantEncodingDecoder implements EncodingDecoder {
2828

29-
/// Public no-arg constructor required by [java.util.ServiceLoader].
30-
public ConstantEncodingDecoder() {
31-
}
32-
3329
@Override
3430
public EncodingId encodingId() {
3531
return EncodingId.VORTEX_CONSTANT;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/DateTimePartsEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,6 @@ public final class DateTimePartsEncodingDecoder implements EncodingDecoder {
2323

2424
private static final long SECONDS_PER_DAY = 86_400L;
2525

26-
/// Public no-arg constructor required by [java.util.ServiceLoader].
27-
public DateTimePartsEncodingDecoder() {
28-
}
29-
3026
@Override
3127
public EncodingId encodingId() {
3228
return EncodingId.VORTEX_DATETIMEPARTS;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/DecimalBytePartsEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@
1414
/// Read-only decoder for `vortex.decimal_byte_parts`.
1515
public final class DecimalBytePartsEncodingDecoder implements EncodingDecoder {
1616

17-
/// Public no-arg constructor required by [java.util.ServiceLoader].
18-
public DecimalBytePartsEncodingDecoder() {
19-
}
20-
2117
@Override
2218
public EncodingId encodingId() {
2319
return EncodingId.VORTEX_DECIMAL_BYTE_PARTS;

reader/src/main/java/io/github/dfa1/vortex/reader/decode/DecimalEncodingDecoder.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212
/// Read-only decoder for `vortex.decimal`.
1313
public final class DecimalEncodingDecoder implements EncodingDecoder {
1414

15-
/// Public no-arg constructor required by [java.util.ServiceLoader].
16-
public DecimalEncodingDecoder() {
17-
}
18-
1915
@Override
2016
public EncodingId encodingId() {
2117
return EncodingId.VORTEX_DECIMAL;

0 commit comments

Comments
 (0)