Commit ff4a6a0
fix: propagate row validity through wrapper decoders; NullArray CSV export
Files from the Python bindings (vortex-data 0.69.0) carry row validity
deep in the encoding tree, in three representations our decoders
flattened away — every one silent corruption (nulls exported as
invented values), found by the Raincloud conformance suite (#205):
- a trailing bool validity child on fastlanes.bitpacked, reached
through vortex.alp / vortex.zigzag / fastlanes.for, which per the
Rust ValidityChild contract delegate their validity to the encoded
child. AlpEncodingDecoder and ZigZagEncodingDecoder now decode that
child as an Array (nullability inherited from the parent dtype),
split off a MaskedArray, and re-wrap their result — the pattern
FrameOfReferenceEncodingDecoder already used. Bitpacked decodes the
trailing validity child at the index its patch shape dictates
(0 / 2 / 3, mirroring the Rust vtable deserialize).
- dict pools with invalid slots: null rows are codes pointing at an
invalid pool entry; slot validity is now gathered through the codes
into per-row validity.
- dict codes with their own validity child: propagated directly, and
combined with pool validity when both are present. Applied to the
eager vortex.dict decoder (primitive + utf8 paths) and the lazy dict
layout path.
Also: CSV export renders all-null (DType.Null) columns as empty fields
instead of throwing (kepler has fully-empty columns).
Corpus evidence: penguins bill_length/bill_depth and 20k+ kepler cells
exported values where the file holds nulls (verified against both the
Parquet oracle and the Python bindings reading the same file). After
the fix kepler passes value-for-value on all 153 columns and flips to
ok in the conformance matrix; penguins' remaining failure is #208 only.
Closes #210
Closes #211
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent a9e4137 commit ff4a6a0
10 files changed
Lines changed: 290 additions & 32 deletions
File tree
- csv/src
- main/java/io/github/dfa1/vortex/csv
- test/java/io/github/dfa1/vortex/csv
- docs
- integration/src/test/resources/raincloud
- reader/src/main/java/io/github/dfa1/vortex/reader
- decode
- layout
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
154 | 158 | | |
155 | 159 | | |
156 | 160 | | |
| |||
Lines changed: 28 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
69 | 71 | | |
70 | 72 | | |
71 | 73 | | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
72 | 100 | | |
73 | 101 | | |
74 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
Lines changed: 26 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
58 | | - | |
59 | | - | |
60 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
61 | 79 | | |
62 | 80 | | |
| 81 | + | |
63 | 82 | | |
64 | 83 | | |
65 | | - | |
| 84 | + | |
| 85 | + | |
66 | 86 | | |
67 | 87 | | |
68 | 88 | | |
69 | 89 | | |
70 | 90 | | |
71 | 91 | | |
72 | | - | |
73 | 92 | | |
74 | 93 | | |
75 | 94 | | |
| |||
96 | 115 | | |
97 | 116 | | |
98 | 117 | | |
99 | | - | |
| 118 | + | |
| 119 | + | |
100 | 120 | | |
101 | 121 | | |
102 | | - | |
103 | 122 | | |
104 | 123 | | |
105 | 124 | | |
| |||
Lines changed: 40 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
59 | 61 | | |
60 | 62 | | |
61 | 63 | | |
62 | | - | |
| 64 | + | |
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
68 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
69 | 108 | | |
70 | 109 | | |
71 | 110 | | |
| |||
0 commit comments