feat: bind ZSTD_decompressionMargin (in-place decompression)#34
Merged
Conversation
Adds ZstdFrame.decompressionMargin(byte[] / MemorySegment): the extra room needed to decompress a frame in place, where the output buffer overlaps the compressed input at its tail. Size the output buffer at decompressedSize + margin, place the frame at its end, and decompress from that tail slice into the start — no second allocation. Supports multi-frame input. Binds ZSTD_decompressionMargin. The test proves it end to end: it actually decompresses in place through the single-pass ZstdDecompressCtx.decompress(dst, src) and recovers the original from one overlapping buffer. docs/supported.md: memory sizing 8 -> 9/14. CHANGELOG updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ZstdFrame.decompressionMargin(byte[] / MemorySegment)— the extra room needed to decompress a frame in place, where the output buffer overlaps the compressed input at its tail. BindsZSTD_decompressionMargin.Usage: size the output buffer at
decompressedSize + margin, place the compressed frame(s) at its end, then decompress from that tail slice into the start — no second allocation. Supports multi-frame input. On-theme with the zero-copy story.Tests
ZstdFrameTest.DecompressionMargin— positive margin, segment parity, garbage rejected, and the key one: an actual in-place round-trip throughZstdDecompressCtx.decompress(dst, src)(single-passZSTD_decompressDCtx) recovering the original from one overlapping buffer. 236 tests green, checkstyle + javadoc clean.Note
Did not bind
ZSTD_decodingBufferSize_min— it only serves the buffer-less streaming API (ZSTD_decompressContinue), which isn't bound, so it's useless on its own.Docs
docs/supported.md: memory sizing 8 → 9/14.CHANGELOG.mdupdated.🤖 Generated with Claude Code