refactor(test): extract shared ZstdTestSupport, dedup helpers#40
Merged
Conversation
Pull duplicated unit-test helpers into a package-private ZstdTestSupport: segmentOf(Arena,byte[]), bytesOf(MemorySegment,long/int), and trainDictionary(int) (one sample schema, caller-chosen count). Hoist the byte-for-byte nativeDict(...) duplicate in ZstdDictionaryTest up to the outer class. Update ZstdSegment/SegmentStream/RefPrefix/Stream/Frame/Memory tests to use it. Test-only: no production change, no assertions changed, counts preserved (3000/2000). 261 tests pass, checkstyle clean. ~67 lines removed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure test-helper deduplication — no production code, no assertion changes.
What
ZstdTestSupport:segmentOf(Arena, byte[]),bytesOf(MemorySegment, long)+intoverload,trainDictionary(int sampleCount)nativeDict(...)duplicate inZstdDictionaryTest(two nested classes) up to the outer classZstdSegmentTest,ZstdSegmentStreamTest,RefPrefixTest,ZstdStreamTest,ZstdFrameTest,ZstdMemoryTestto use itSafety
ZstdDictionaryTest's richerrecord()schema left local (a test depends on it)🤖 Generated with Claude Code