chore: stop the review agent from manufacturing nits#41
Merged
Conversation
The reviewer's findings-template output pressured it to always produce a list; once real issues were gone it padded with cosmetic nits (label choices, inline FQNs) that the author was told to ignore. Make an empty findings list an explicitly valid outcome, restrict Nits to ones worth a human's time, and state that coverage is not measured by finding count. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zstd-revieweragent's Blocker/Should-fix/Nit template pressured it to always return a non-empty list; once real issues were gone it padded with cosmetic nits it then told the author to ignore — noise, not signal.Agent-config only.
🤖 Generated with Claude Code