Skip to content

chore: stop the review agent from manufacturing nits #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfa1 merged 1 commit into from
Jun 27, 2026
Merged

chore: stop the review agent from manufacturing nits #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .claude/agents/zstd-reviewer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ Read `CLAUDE.md` first. Review against it strictly. Start by running `git diff`
- No `sun.misc.Unsafe` / internal JDK APIs. No SonarQube smells.

## Output format
Group findings by severity: **Blocker** / **Should-fix** / **Nit**. Each finding one line: `file:line — problem — fix`. If you can, verify suspicions by running `./mvnw validate` or the relevant test and quote real output. End with a verdict: APPROVE or CHANGES NEEDED. Be specific and skeptical — your job is to catch what the coder missed.
Group findings by severity: **Blocker** / **Should-fix** / **Nit**. Each finding one line: `file:line — problem — fix`. If you can, verify suspicions by running `./mvnw validate` or the relevant test and quote real output. End with a verdict: APPROVE or CHANGES NEEDED.

Be specific and skeptical about correctness — your job is to catch what the coder missed. But **do not manufacture findings to fill the template**: an empty findings list is a valid, good outcome. A clean diff should get "APPROVE — nothing material." Report **Blocker** and **Should-fix** whenever they exist; report a **Nit only when it is genuinely worth a human's time to act on** (a real readability or correctness-adjacent issue), not for cosmetic preferences, style the build already enforces, or anything you'd caveat with "acceptable as-is / leave it." If your only findings are ones you'd tell the author to ignore, omit them and approve. Coverage is not measured by finding count.
Loading