Add map search for elements, trips, and places#14
Merged
Conversation
Users had no way to find something not already in the current viewport. This adds a search overlay that queries elements, trips, and places in a single request and lets the user jump to a result: - Element with a location: fly to it and show the preview card. One with no coordinates can't be placed on the map, so its detail modal opens directly instead of a card pinned over an unrelated view. - Trip: filter the map to that trip's elements only, fit the camera to their extent, and show a clearable filter chip. - Place: recenter at a zoom matched to the place's size (country vs city). Search runs on submit (not typeahead); the query and results persist across dismiss so reopening shows the last search, editable. The single Elements query gained an optional tripId so one hook/cache serves both the viewport and trip-filtered views. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a search overlay on the map that queries elements, trips, and places in a single request, with type-specific behavior on select:
country → 4…city → 11), viaplaceSearch(granularity: REGIONS).UX details
Implementation
SearchGraphQL operation; the existingElementsquery gained an optional$tripIdso one hook + Apollo cache serves both the viewport and trip-filtered views.SearchOverlay,TripFilterChip; pure helperplaceZoom(with unit tests).MapScreenswaps query variables (bounds ↔ tripId) and the displayed-element source based on the active trip filter.Verification
tsc,biome, and jest (5 tests) pass.