Dismiss keyboard when collapsing search from a result tap#15
Merged
Conversation
Selecting a result after reopening the search left the soft keyboard up: on first search it was dismissed only as a side effect of pressing the keyboard's search key, never by our own code. Collapse now dismisses the keyboard explicitly so every dismiss path (result tap, tap-outside) hides it consistently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collapse()now callsKeyboard.dismiss()explicitly, so every dismiss path (result tap, tap-outside) hides the keyboard consistently.Testing
Verified on the emulator (with
show_ime_with_hard_keyboardenabled so the soft keyboard renders), walking the exact repro — search → select → reopen → select another.dumpsys input_methodconfirmsmInputShown=falseafter the final selection.