Make element details a navigation screen instead of an in-tree modal#17
Merged
Conversation
The account menu (a root-level sibling rendered after MapScreen) always painted over the hand-rolled fullscreen detail Sheet, since RN paint order follows tree order and there is no cross-tree z-index. Promoting element details to a real native-stack screen lets it cover the whole map screen, account menu included, and sets up Trip/Place detail to follow the same path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MapScreen, so it (and its sheet) always painted over the hand-rolled fullscreen detailSheet— RN paint order follows tree order and there's no cross-tree z-index. Fixed by promoting element details to a real screen.@react-navigation/native+ native-stack (react-native-screens). Authed app now renders aNavigationContainerwithMapandElementDetailroutes; the detail screen covers the whole map screen, account menu included.AccountMenuout ofApp.tsxintosrc/account/AccountMenu.tsxand rendered it insideMapScreen(it's map chrome) so pushed screens cover it.ElementDetailModal→ElementDetailScreen(readsroute.params.elementId, closes viagoBack()); dropped the fullscreenSheetvariant, which is now dead.MapScreendrops itsdetailElementIdstate; the preview card's expand and the location-less search branchnavigate()instead. Map stays mounted underneath, so camera/viewport and the preview-card fallback survive push/pop.MainActivity.kt:super.onCreate(null), required byreact-native-screens.slide_from_rightforward transition.Notes
react-native-screensis native, so this needs a rebuild (bun install+npx react-native run-android) — not just a Metro reload.Verification
tsc --noEmit,biome check, andjest(5/5) all pass.