Add label filtering to the map#25
Merged
Merged
Conversation
Lets users narrow the map by tapping a label in an element's details: the detail view closes and that label becomes an active filter. Labels combine with an existing trip filter (and with each other, ALL-matched) so several constraints can apply at once, each shown as its own clearable pill. This turns the labels already shown on elements into a navigation affordance rather than static decoration. The trip and label pills now share one FilterPill renderer (icon + title + clear), with a tag glyph standing in for a label's icon, replacing the single-purpose TripFilterChip. Also pin react to 19.2.3 to match react-native-renderer: react-native 0.85.3 bundles renderer 19.2.3 and React requires an exact match, so the Renovate bump to 19.2.7 (#22) crashed the app at launch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilterPillrenderer (icon + title + clear); a tag glyph stands in for a label's icon. This replaces the single-purposeTripFilterChip.Elements/Searchqueries now requestlabels, andElementsacceptslabels/labelsMatchso filtering happens server-side; the map also filters accumulated pins client-side to avoid a refetch flash.Notes
react-native@0.85.3bundlesreact-native-renderer@19.2.3and React requires an exact match, so the Renovate bump in Update react to v19.2.7 #22 crashed the app at launch before any feature code ran. CI didn't catch it since it doesn't boot the app on a device. Worth a Renovate constraint soreactcan't outpacereact-native's renderer again.codegencan't run here (schema isn't committed percodegen.ts), so the generatedtypes.tschanges were applied by hand and verified withtsc.Test plan
bunx tsc --noEmit,bun run lint,bun run testall pass.