Fix Wikimedia photos not rendering on Android#38
Merged
Conversation
Wikimedia's User-Agent policy returns 403 to the generic okhttp UA that React Native's native image loader sends on Android, so wikimedia-type photos never rendered (web works because browsers send a full UA). Attach a descriptive UA to photo Image requests to satisfy the policy. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wikimedia-type photos failed to render on Android while loading fine on web. Wikimedia's User-Agent policy returns403to the genericokhttp/...User-Agent that React Native's native image loader sends; browsers send a fullMozilla/...UA, which is why web was unaffected.src/photos/photoImageSource.ts, a helper that attaches a descriptiveUser-Agentheader to photoImagerequests. Applied inElementDetailScreenandElementEditScreen. The header is harmless for our S3/Cloudinary-hosted photos, so it's applied to all.Verification
okhttp/4.9.2→403; descriptiveCulpeos/...UA →200.tsc --noEmit,bun run lint(no new warnings), andbun run testall pass.🤖 Generated with Claude Code