Merge pull request #10 from dfeen87/copilot/fix-code-bugs

Fix velocity validation logic and chrono API misuse

Author: dfeen87

.gitignore

@@ -0,0 +1,29 @@
+# Build directories
+build/
+dist/
+_codeql_build_dir/
+*.o
+*.a
+*.so
+*.dylib
+*.exe
+
+# CodeQL
+_codeql_detected_source_root
+
+# IDE
+.vscode/
+.idea/
+*.swp
+*.swo
+*~
+
+# Coverage
+*.gcda
+*.gcno
+*.gcov
+coverage/
+
+# Temporary files
+/tmp/
+*.tmp

examples/hil/hil_rig_server.cpp

@@ -42,7 +42,7 @@ static constexpr size_t   MAX_LINE = 1024 * 1024;
 
 uint32_t now_ms() {
     auto ms = std::chrono::duration_cast<std::chrono::milliseconds>(
-        std::chrono::steady_clock::now().time_since_epoch()
+        std::chrono::system_clock::now().time_since_epoch()
     ).count();
     return static_cast<uint32_t>(ms);
 }

include/PropulsionPhysicsEngine.hpp

@@ -10,6 +10,7 @@ class PropulsionPhysicsEngine {
     static constexpr float MAX_THRUST_kN = 2500.0f;
     static constexpr float MIN_MASS_KG = 100.0f;
     static constexpr float MIN_VELOCITY_M_S = -20000.0f;
+    static constexpr float MAX_VELOCITY_M_S = 20000.0f;  // ~72,000 km/h
     static constexpr uint32_t PHYSICS_DT_MS = 10;
 
     void init();

src/physics/propulsion_physics_engine.cpp

@@ -169,10 +169,10 @@ bool PropulsionPhysicsEngine::is_state_physically_plausible(
     if (radius_sq < min_radius * min_radius)
         return false;
 
-    // Velocity sanity check
-    if (state.velocity_m_s[0] < MIN_VELOCITY_M_S ||
-        state.velocity_m_s[1] < MIN_VELOCITY_M_S ||
-        state.velocity_m_s[2] < MIN_VELOCITY_M_S)
+    // Velocity sanity check (magnitude per component)
+    if (std::abs(state.velocity_m_s[0]) > MAX_VELOCITY_M_S ||
+        std::abs(state.velocity_m_s[1]) > MAX_VELOCITY_M_S ||
+        std::abs(state.velocity_m_s[2]) > MAX_VELOCITY_M_S)
         return false;
 
     return true;