Review comments

Author: spoorcc

dfetch/commands/remove.py

@@ -51,7 +51,7 @@ def __call__(self, args: argparse.Namespace) -> None:
 
             # Pre-validate all projects and collect their destinations
             projects_to_remove = []
-            for project in args.projects:
+            for project in list(dict.fromkeys(args.projects)):
                 try:
                     project_entries = superproject.manifest.selected_projects([project])
                     destination = project_entries[0].destination

tests/manifest_mock.py

@@ -23,12 +23,15 @@ def mock_manifest(projects, path: str = "/some/path") -> MagicMock:
     def mock_selected_projects(names):
         if not names:
             return project_mocks
-        filtered = [p for p in project_mocks if p.name in names]
-        if len(filtered) != len(names):
+        deduped_names = list(dict.fromkeys(names))
+        filtered = [p for p in project_mocks if p.name in deduped_names]
+        if len(filtered) != len(deduped_names):
             from dfetch.manifest.manifest import RequestedProjectNotFoundError
 
             unfound = [
-                name for name in names if not any(p.name == name for p in project_mocks)
+                name
+                for name in deduped_names
+                if not any(p.name == name for p in project_mocks)
             ]
             possibles = [p.name for p in project_mocks]
             raise RequestedProjectNotFoundError(unfound, possibles)