Review comments

Author: spoorcc

dfetch/project/subproject.py

@@ -399,7 +399,7 @@ def diff(self, old_rev: str, new_rev: str) -> str:
             raise RuntimeError(
                 "When not providing any revisions, dfetch starts from"
                 f" the last revision to {Metadata.FILENAME} in {self.local_path}."
-                " Please either revision this, or specify a revision to start from with --revs"
+                " Please either commit this, or specify a revision to start from with --revs"
             )
 
         return self._diff_impl(old_rev, new_rev, ignore=(Metadata.FILENAME,))

dfetch/vcs/svn.py

@@ -18,6 +18,8 @@ def get_svn_version() -> tuple[str, str]:
     """Get the name and version of svn."""
     result = run_on_cmdline(logger, ["svn", "--version", "--non-interactive"])
     first_line = result.stdout.decode().split("\n")[0]
+    if "version" not in first_line.lower():
+        raise RuntimeError(f"Unexpected svn --version output format: {first_line}")
     tool, version = first_line.replace(",", "").split("version", maxsplit=1)
     return (str(tool), str(version))
 
@@ -251,7 +253,7 @@ def export(url: str, rev: str = "", dst: str = ".") -> None:
         run_on_cmdline(
             logger,
             ["svn", "export", "--non-interactive", "--force"]
-            + rev.split(" ")
+            + (rev.split(" ") if rev else [])
             + [url, dst],
         )