Minor review fixups

Author: spoorcc

dfetch/project/svn.py

@@ -424,9 +424,9 @@ def _untracked_files(path: str, ignore: Sequence[str]) -> list[str]:
         files = []
         for line in result:
             if line.startswith("?"):
-                files.append(line[1:].strip())
-                for pattern in ignore:
-                    if pathlib.Path(line[1:].strip()).match(pattern):
-                        files.pop()
-                        break
+                file_path = line[1:].strip()
+                if not any(
+                    pathlib.Path(file_path).match(pattern) for pattern in ignore
+                ):
+                    files.append(file_path)
         return files

dfetch/vcs/git.py

@@ -338,7 +338,6 @@ def create_diff(
 
             if ignore:
                 cmd.extend(["--", "."])
-                ignore = ignore or []
                 for ignore_path in ignore:
                     cmd.append(f":(exclude){ignore_path}")
             result = run_on_cmdline(logger, cmd)

features/journey-basic-patching.feature

@@ -1,6 +1,6 @@
 Feature: Basic patch journey
 
-    The main user journey is for patching is:
+    The main user journey for patching is:
     - Adding a project to a manifest
     - Fetching the new project and committing it.
     - Changing files in the fetched project.