Review comments

Author: spoorcc

doc/conf.py

@@ -110,8 +110,6 @@
 # This patterns also effect to html_static_path and html_extra_path
 exclude_patterns = ["_build", "Thumbs.db", ".DS_Store", "venv", "landing-page"]
 
-# The name of the Pygments (syntax highlighting) style to use.
-pygments_style = "dfetch"
 
 # If true, `todo` and `todoList` produce output, else they produce nothing.
 todo_include_todos = False
@@ -277,6 +275,16 @@
 ]
 
 
+def _set_latex_pygments_style(app):
+    if app.builder.name.startswith("latex"):
+        app.config.pygments_style = "dfetch"
+
+
+def setup(app):
+    """Apply custom Pygments style only for LaTeX builds."""
+    app.connect("builder-inited", _set_latex_pygments_style)
+
+
 # -- Options for manual page output ---------------------------------------
 
 # One entry per manual page. List of tuples

doc/dfetch_preamble.inc

@@ -69,11 +69,10 @@
 \usepackage{etoolbox}
 \setlength{\arrayrulewidth}{0.4pt}
 \arrayrulecolor{dfborder}
-\renewcommand{\vline}{}                % suppress all vertical column rules
 \renewcommand{\arraystretch}{1.35}     % generous row height (website 0.5rem top/bottom)
 \setlength{\tabcolsep}{8pt}            % horizontal cell padding (website 0.875rem)
-\AtBeginEnvironment{tabulary}{\small}
-\AtBeginEnvironment{longtable}{\small}
+\AtBeginEnvironment{tabulary}{\small\renewcommand{\vline}{}}
+\AtBeginEnvironment{longtable}{\small\renewcommand{\vline}{}}
 \providecommand{\sphinxstyletheadfamily}{\sffamily}
 \renewcommand{\sphinxstyletheadfamily}{\small\bfseries}
 

doc/howto/patching.rst

@@ -134,20 +134,14 @@ You can verify the formatted patch applies cleanly before submitting:
 
             $ git apply --check formatted-some-project.patch
 
+        .. scenario-include:: ../features/format-patch-in-git.feature
+
     .. tab:: SVN
 
         .. code-block:: console
 
             $ svn patch formatted-some-project.patch
 
-.. asciinema:: ../asciicasts/format-patch.cast
-
-.. tabs::
-
-    .. tab:: Git
-
-        .. scenario-include:: ../features/format-patch-in-git.feature
-
-    .. tab:: SVN
-
         .. scenario-include:: ../features/format-patch-in-svn.feature
+
+.. asciinema:: ../asciicasts/format-patch.cast