Fix review comments

Author: spoorcc

dfetch/reporting/sbom_reporter.py

@@ -81,6 +81,7 @@ def add_project(
             component.group = purl.namespace
 
             vcs_url = purl.qualifiers.get("vcs_url", "")
+            # ExternalReferenceType.VCS does not support ssh:// urls
             if vcs_url and "ssh://" not in vcs_url:
                 component.external_references.add(
                     ExternalReference(

dfetch/util/purl.py

@@ -10,6 +10,7 @@
 from packageurl import PackageURL
 from tldextract import TLDExtract
 
+# Although tldextract can fetch the latest suffix list, we don't want that here
 NO_FETCH_EXTRACT = TLDExtract(suffix_list_urls=(), extra_suffixes=("local",))
 
 # Matches SSH-style Git URLs like:
@@ -94,7 +95,9 @@ def remote_url_to_purl(
 
     if "svn" in parsed.scheme or "svn." in parsed.netloc:
         namespace, name = _namespace_and_name_from_domain_and_path(parsed.netloc, path)
-        namespace = namespace.replace("/svn/", "/").removeprefix("p/")
+        if namespace.startswith("p/"):
+            namespace = namespace[len("p/") :]
+        namespace = namespace.replace("/svn/", "/")
 
     else:
         match = SSH_REGEX.match(remote_url)

features/steps/generic_steps.py

@@ -113,10 +113,9 @@ def check_content(
             text=actual,
         )
 
-        assert actual.strip() == expected.strip(), "\n".join(
-            f"Line {line_nr}: Actual >>{actual.strip()}<< != Expected >>{expected.strip()}<<",
-            "ACTUAL:",
-            *actual_content,
+        assert actual.strip() == expected.strip(), (
+            f"Line {line_nr}: Actual >>{actual.strip()}<< != Expected >>{expected.strip()}<<\n"
+            f"ACTUAL:\n{''.join(actual_content)}"
         )