Simplify diff

Author: ben-edna

dfetch/commands/diff.py

@@ -153,13 +153,25 @@ def __call__(self, args: argparse.Namespace) -> None:
                     f"No (such) project found! {', '.join(args.projects)}"
                 )
             for project in projects:
-                patch_name = f"{project.name}.patch"
                 with catch_runtime_exceptions(exceptions) as exceptions:
                     patch = _get_sub_project(superproject, project).diff(revs)
 
-                    _dump_patch(
-                        superproject.root_directory, revs, project, patch_name, patch
+                    rev_range = (
+                        f"from {revs[0]} to {revs[1]}"
+                        if revs[1]
+                        else f"since {revs[0]}"
                     )
+                    if patch:
+                        patch_path = pathlib.Path(f"{project.name}.patch")
+                        logger.print_info_line(
+                            project.name,
+                            f"Generating patch {patch_path} {rev_range} in {superproject.root_directory}",
+                        )
+                        patch_path.write_text(patch, encoding="UTF-8")
+                    else:
+                        logger.print_info_line(
+                            project.name, f"No diffs found {rev_range}"
+                        )
 
         if exceptions:
             raise RuntimeError("\n".join(exceptions))
@@ -179,23 +191,3 @@ def _get_sub_project(superproject: SuperProject, project: ProjectEntry) -> SubPr
     raise RuntimeError(
         "Can only create patch if your project is an SVN or Git repo",
     )
-
-
-def _dump_patch(
-    path: str, revs: list[str], project: ProjectEntry, patch_name: str, patch: str
-) -> None:
-    """Dump the patch to a file."""
-    if patch:
-        rev_range = f"from {revs[0]} to {revs[1]}" if revs[1] else f"since {revs[0]}"
-        logger.print_info_line(
-            project.name,
-            f"Generating patch {patch_name} {rev_range} in {os.path.dirname(path)}",
-        )
-        pathlib.Path(patch_name).write_text(patch, encoding="UTF-8")
-    else:
-        if revs[1]:
-            msg = f"No diffs found from {revs[0]} to {revs[1]}"
-        else:
-            msg = f"No diffs found since {revs[0]}"
-
-        logger.print_info_line(project.name, msg)