Review comments

Author: spoorcc

dfetch/commands/check.py

@@ -109,14 +109,15 @@ def __call__(self, args: argparse.Namespace) -> None:
                         reporters,
                         files_to_ignore=superproject.ignored_files(project.destination),
                     )
+                    if not args.no_recommendations and os.path.isdir(
+                        project.destination
+                    ):
+                        with in_directory(project.destination):
+                            check_sub_manifests(superproject.manifest, project)
                 except RuntimeError as exc:
                     logger.print_warning_line(project.name, str(exc))
                     had_errors = True
 
-                if not args.no_recommendations and os.path.isdir(project.destination):
-                    with in_directory(project.destination):
-                        check_sub_manifests(superproject.manifest, project)
-
             for reporter in reporters:
                 reporter.dump_to_file()
 

dfetch/commands/freeze.py

@@ -100,6 +100,7 @@ def __call__(self, args: argparse.Namespace) -> None:
         make_backup = isinstance(superproject, NoVcsSuperProject)
 
         manifest_updated = False
+        had_errors = False
 
         with in_directory(superproject.root_directory):
             manifest_path = superproject.manifest.path
@@ -134,7 +135,11 @@ def __call__(self, args: argparse.Namespace) -> None:
                         manifest_updated = True
                 except RuntimeError as exc:
                     logger.print_warning_line(project.name, str(exc))
+                    had_errors = True
 
             if manifest_updated:
                 superproject.manifest.dump()
                 logger.info(f"Updated manifest ({manifest_path}) in {os.getcwd()}")
+
+        if had_errors:
+            raise RuntimeError()