Prepare 0.14.2 and fix WinGet egress policy#1298
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughTwo endpoints ( ChangesWinGet Publish Egress Fix and Changelog
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add static.crates.io:443 and objects.githubusercontent.com:443 to the winget-publish egress allowlist. cargo-binstall fetches the komac source tarball from static.crates.io to read binstall metadata (even for binary installs), and the komac binary/dfetch MSI are served from objects.githubusercontent.com. These two missing endpoints caused the WinGet publish step to fail for 0.14.0 (index.crates.io) and 0.14.1 (static.crates.io) respectively. Bump version to 0.14.2 and open the changelog for the new cycle.
Propagate the version bump to all BDD feature expected outputs. Note: this is the manual equivalent of running script/release.py — pending discussion on whether to revert the version bump and keep __version__ at 0.14.1 until actual release time.
The version bump and feature file propagation belong at release time (via script/release.py), not in the post-release prep commit. Only the CHANGELOG unreleased header and the winget egress fix are needed on this branch.
a3534bd to
40360af
Compare
Add static.crates.io:443 and objects.githubusercontent.com:443 to the
winget-publish egress allowlist. cargo-binstall fetches the komac source
tarball from static.crates.io to read binstall metadata (even for binary
installs), and the komac binary/dfetch MSI are served from
objects.githubusercontent.com. These two missing endpoints caused the
WinGet publish step to fail for 0.14.0 (index.crates.io) and 0.14.1
(static.crates.io) respectively.
Bump version to 0.14.2 and open the changelog for the new cycle.
Summary by CodeRabbit