Add pyright

[spoorcc]

Add some more checkers to dfetch

Description by Korbit AI

What change is being made?

Add pyright for type checking and validate type-related improvements across multiple files in the repository.

Why are these changes being made?

Pyright is being integrated into the development workflow to enhance type checking capabilities and ensure type correctness throughout the codebase. This includes modifications to type hints, resolving Pyright issues, and improving code robustness by explicitly handling potential exceptions or type errors. These changes are driven by the need to maintain code quality, improve maintenance, and prevent type-related bugs.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

[ben-edna]

/korbit-generate-pr-description /korbit-review

[korbit-ai]

@ben-edna I am looking at your pull request. The description will be updated shortly. In the meantime, please do not edit the description until I have finished writing mine.

[korbit-ai]

I've completed my review and didn't find any issues... but I did find this frog.

           .--._.--.
          ( O     O )
          /   . .   \
         .`._______.'.
        /(           )\
      _/  \  \   /  /  \_
   .~   `  \  \ /  /  '   ~.
  {    -.   \  V  /   .-    }
_ _`.    \  |  |  |  /    .'_ _
>_       _} |  |  | {_       _<
 /. - ~ ,_-'  .^.  `-_, ~ - .\
         '-'|/   \|`-`

Files scanned

​

File Path	Reviewed
features/steps/manifest_steps.py	✅
features/steps/svn_steps.py	✅
doc/_ext/scenario_directive.py	✅
dfetch/reporting/sbom_reporter.py	✅
doc/static/uml/generate_diagram.py	✅
features/steps/git_steps.py	✅
dfetch/project/metadata.py	✅
doc/landing-page/conf.py	✅
features/steps/generic_steps.py	✅
dfetch/reporting/check/sarif_reporter.py	✅
dfetch/project/vcs.py	✅
dfetch/vcs/git.py	✅
dfetch/manifest/project.py	✅
dfetch/manifest/manifest.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

• You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
• You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
• Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
• On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
• Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

• Check out our docs on how you can make Korbit work best for you and your team.
• Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings

​

Setting	Value
Review Schedule	Automatic excluding drafts
Max Issue Count	10
Automatic PR Descriptions	✅

Issue Categories

​

Category	Enabled
Documentation	✅
Logging	✅
Error Handling	✅
Readability	✅
Design	✅
Performance	✅
Security	✅
Functionality	✅

Feedback and Support

• Tell us what you think of Korbit
• Schedule a call with our team
• Email us @ support@korbit.ai

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

[ben-edna]

/korbit-generate-pr-description

[korbit-ai]

@ben-edna I am looking at your pull request. The description will be updated shortly. In the meantime, please do not edit the description until I have finished writing mine.