Skip to content

Add correct permissions for uploading sarif#799

Merged
spoorcc merged 1 commit intomainfrom
hotfix/permissions-sarif-upload
Oct 3, 2025
Merged

Add correct permissions for uploading sarif#799
spoorcc merged 1 commit intomainfrom
hotfix/permissions-sarif-upload

Conversation

@ben-edna
Copy link
Copy Markdown
Contributor

@ben-edna ben-edna commented Oct 3, 2025

Sarif uploading fails in main because security-events: write permission is required

Description by Korbit AI

What change is being made?

Set GitHub Actions job permissions to allow uploading SARIF by adding:

  • permissions: contents: read
  • permissions: security-events: write
    to both test-cygwin and matrix-based jobs in .github/workflows/run.yml.

Why are these changes being made?

To enable uploading SARIF results from the workflow (code scanning) by granting the necessary security-events permission; this ensures SARIF data can be published during runs.

Is this description stale? Ask me to generate a new description by commenting /korbit-generate-pr-description

Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this dinosaur.

            __
           / _)
    .-^^^-/ /
 __/       /
<__.|_|-|_|

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@spoorcc spoorcc merged commit 111c3c1 into main Oct 3, 2025
30 checks passed
@spoorcc spoorcc deleted the hotfix/permissions-sarif-upload branch October 3, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants