Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Misleading variable name ▹ view | |
 |
Redundant file reads on encoding fallback ▹ view | |
 |
Missing context in UnicodeDecodeError handler ▹ view | |
|
Incomplete file operation error handling ▹ view | |
|
Incomplete exception handling for file encoding ▹ view | |
 |
Improve License class docstring ▹ view | |
|
Incomplete function docstring ▹ view | |
|
Unnecessary license file processing ▹ view | |
|
Unexplained Magic Number for License Threshold ▹ view | |
 |
Empty licenses list produces unclear output ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| dfetch/reporting/reporter.py | ✅ |
| dfetch/util/license.py | ✅ |
| dfetch/reporting/stdout_reporter.py | ✅ |
| dfetch/reporting/sbom_reporter.py | ✅ |
| dfetch/commands/report.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
spoorcc
force-pushed
the
spoorcc/issue788
branch
from
9c2fb16 to
c3fa5c2
Compare
spoorcc
force-pushed
the
spoorcc/issue788
branch
from
15ce10e to
0de8e2b
Compare
spoorcc
force-pushed
the
spoorcc/issue788
branch
from
0de8e2b to
4d109e6
Compare
Contributor
Author
|
/korbit-review /korbit-generate-pr-description |
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unused Parameter in Interface ▹ view | |
|
Unescaped regex pattern in name search ▹ view | |
|
Unbounded file read into memory ▹ view | |
|
Improve License class docstring ▹ view | |
|
Incomplete from_inferred method docstring ▹ view | |
|
Unused manifest storage in abstract reporter ▹ view | |
|
Missing project name in error message ▹ view | |
|
Unclear return value documentation ▹ view | |
|
Unnecessary string conversion of None values ▹ view | |
|
Redundant file reading operations ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| dfetch/reporting/reporter.py | ✅ |
| dfetch/reporting/stdout_reporter.py | ✅ |
| dfetch/commands/common.py | ✅ |
| dfetch/util/license.py | ✅ |
| dfetch/commands/freeze.py | ✅ |
| dfetch/reporting/check/jenkins_reporter.py | ✅ |
| dfetch/reporting/check/code_climate_reporter.py | ✅ |
| dfetch/commands/report.py | ✅ |
| dfetch/commands/check.py | ✅ |
| dfetch/commands/diff.py | ✅ |
| dfetch/commands/update.py | ✅ |
| dfetch/reporting/check/sarif_reporter.py | ✅ |
| dfetch/reporting/check/reporter.py | ✅ |
| dfetch/reporting/sbom_reporter.py | ✅ |
| dfetch/manifest/manifest.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Contributor
Author
|
/korbit-generate-pr-description |
|
@spoorcc I am looking at your pull request. The description will be updated shortly. In the meantime, please do not edit the description until I have finished writing mine. |
spoorcc
force-pushed
the
spoorcc/issue788
branch
from
4d109e6 to
24afe88
Compare
Contributor
Author
|
/korbit-review |
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
|
Unclear constant documentation ▹ view | |
|
Redundant error handling comments ▹ view | |
|
Missing encoding strategy documentation ▹ view | |
|
Non-informative constant comment ▹ view | |
 |
Non-standard warning logging method ▹ view | |
|
Abstract init method prevents normal inheritance ▹ view | |
|
Unused Constructor Parameter ▹ view | |
|
Unclear parameter deletion rationale ▹ view | |
|
Unclear constant definition ▹ view | |
|
Method with Multiple Responsibilities ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| dfetch/reporting/reporter.py | ✅ |
| dfetch/reporting/stdout_reporter.py | ✅ |
| dfetch/commands/common.py | ✅ |
| dfetch/commands/freeze.py | ✅ |
| dfetch/util/license.py | ✅ |
| dfetch/reporting/check/jenkins_reporter.py | ✅ |
| dfetch/reporting/check/code_climate_reporter.py | ✅ |
| dfetch/commands/report.py | ✅ |
| dfetch/commands/check.py | ✅ |
| dfetch/commands/diff.py | ✅ |
| dfetch/commands/update.py | ✅ |
| dfetch/reporting/check/sarif_reporter.py | ✅ |
| dfetch/reporting/check/reporter.py | ✅ |
| dfetch/reporting/sbom_reporter.py | ✅ |
| dfetch/manifest/manifest.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
spoorcc
force-pushed
the
spoorcc/issue788
branch
from
24afe88 to
b1d5dcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #788
Description by Korbit AI
What change is being made?
Refactor the codebase to pass and expose Manifest objects throughout, add manifest path/text tracking and a location helper, implement a license inference utility, expand SBOM and reporting capabilities with evidence and multiple licenses, and update tests accordingly.
Why are these changes being made?
To improve traceability and accuracy of reports (license detection, project location in manifests) and to support richer SBOM data (evidence, multiple licenses) by centralizing manifest handling and providing location-aware tooling. This approach enables more robust reporting and auditing without changing core project behavior.