Skip to content

feat(registry): Added StandardEngineReplicaVersionRecord proto and corresponding key.#10774

Merged
daniel-wong-dfinity-org-twin merged 1 commit into
masterfrom
StandardEngineReplicaVersionRecord-daniel-wong
Jul 16, 2026
Merged

feat(registry): Added StandardEngineReplicaVersionRecord proto and corresponding key.#10774
daniel-wong-dfinity-org-twin merged 1 commit into
masterfrom
StandardEngineReplicaVersionRecord-daniel-wong

Conversation

@daniel-wong-dfinity-org-twin

@daniel-wong-dfinity-org-twin daniel-wong-dfinity-org-twin commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This isn't used yet. The plan is, later, this will be used to determine what Replica version engines run.

Next PR 👉

github-actions[bot]

This comment was marked as resolved.

@zeropath-ai

zeropath-ai Bot commented Jul 14, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to eb3ab99.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► rs/protobuf/def/registry/standard_engine_replica_version/v1/standard_engine_replica_version.proto
    Add StandardEngineReplicaVersionRecord message with deployment_progress field
► rs/protobuf/generator/src/lib.rs
    Include standard_engine_replica_version proto in registry files
► rs/protobuf/src/gen/registry/registry.standard_engine_replica_version.v1.rs
    Add generated ProtoRust binding for StandardEngineReplicaVersionRecord
► rs/protobuf/src/registry.rs
    Register standard_engine_replica_version module
► rs/protobuf/src/registry/standard_engine_replica_version.rs
    Expose v1 module for standard engine replica version
► rs/registry/keys/src/lib.rs
    Add STANDARD_ENGINE_REPLICA_VERSION_RECORD_KEY constant and accessor
► rs/protobuf/generator/src/lib.rs
    Update proto file list to include standard_engine_replica_version.proto

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new registry singleton record for representing the “standard” (default) replica/GuestOS version configuration for engine subnets, along with a dedicated registry key constructor and protobuf plumbing to generate and expose the new type.

Changes:

  • Added a new registry key (standard_engine_replica_version) and a helper to construct it in ic_registry_keys.
  • Added a new protobuf definition StandardEngineReplicaVersionRecord (v1) describing rollout state (new/old version IDs + deployment progress).
  • Wired the new proto into the protobuf generator and exposed it via rs/protobuf module exports (including checked-in generated Rust).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
rs/registry/keys/src/lib.rs Adds the singleton key constant and make_standard_engine_replica_version_record_key() helper.
rs/protobuf/src/registry/standard_engine_replica_version.rs Adds module wrapper exposing generated v1 types.
rs/protobuf/src/registry.rs Exports the new standard_engine_replica_version registry module.
rs/protobuf/src/gen/registry/registry.standard_engine_replica_version.v1.rs Adds generated Rust types for the new proto message.
rs/protobuf/generator/src/lib.rs Includes the new proto file in registry proto compilation inputs.
rs/protobuf/def/registry/standard_engine_replica_version/v1/standard_engine_replica_version.proto Defines the StandardEngineReplicaVersionRecord proto message and documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daniel-wong-dfinity-org-twin
daniel-wong-dfinity-org-twin added this pull request to the merge queue Jul 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 16, 2026
@daniel-wong-dfinity-org-twin
daniel-wong-dfinity-org-twin added this pull request to the merge queue Jul 16, 2026
Merged via the queue into master with commit cc1a281 Jul 16, 2026
45 of 46 checks passed
@daniel-wong-dfinity-org-twin
daniel-wong-dfinity-org-twin deleted the StandardEngineReplicaVersionRecord-daniel-wong branch July 16, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants