feat(registry): Added StandardEngineReplicaVersionRecord proto and corresponding key.#10774
Merged
daniel-wong-dfinity-org-twin merged 1 commit intoJul 16, 2026
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to eb3ab99. Security Overview
Detected Code Changes
|
daniel-wong-dfinity-org-twin
dismissed
github-actions[bot]’s stale review
July 14, 2026 14:14
No behavior change yet.
Copilot started reviewing on behalf of
daniel-wong-dfinity-org-twin
July 14, 2026 14:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a new registry singleton record for representing the “standard” (default) replica/GuestOS version configuration for engine subnets, along with a dedicated registry key constructor and protobuf plumbing to generate and expose the new type.
Changes:
- Added a new registry key (
standard_engine_replica_version) and a helper to construct it inic_registry_keys. - Added a new protobuf definition
StandardEngineReplicaVersionRecord(v1) describing rollout state (new/old version IDs + deployment progress). - Wired the new proto into the protobuf generator and exposed it via
rs/protobufmodule exports (including checked-in generated Rust).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rs/registry/keys/src/lib.rs | Adds the singleton key constant and make_standard_engine_replica_version_record_key() helper. |
| rs/protobuf/src/registry/standard_engine_replica_version.rs | Adds module wrapper exposing generated v1 types. |
| rs/protobuf/src/registry.rs | Exports the new standard_engine_replica_version registry module. |
| rs/protobuf/src/gen/registry/registry.standard_engine_replica_version.v1.rs | Adds generated Rust types for the new proto message. |
| rs/protobuf/generator/src/lib.rs | Includes the new proto file in registry proto compilation inputs. |
| rs/protobuf/def/registry/standard_engine_replica_version/v1/standard_engine_replica_version.proto | Defines the StandardEngineReplicaVersionRecord proto message and documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eichhorl
approved these changes
Jul 14, 2026
daniel-wong-dfinity-org-twin
enabled auto-merge
July 15, 2026 17:42
bjoernek
approved these changes
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
daniel-wong-dfinity-org-twin
deleted the
StandardEngineReplicaVersionRecord-daniel-wong
branch
July 16, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't used yet. The plan is, later, this will be used to determine what Replica version engines run.
Next PR 👉