feat(registry): Added update_standard_engine_replica_version to Registry.#10787
Merged
daniel-wong-dfinity-org-twin merged 2 commits intoJul 16, 2026
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Copilot started reviewing on behalf of
daniel-wong-dfinity-org-twin
July 15, 2026 20:07
View session
|
✅ No security or compliance issues detected. Reviewed everything up to 9bf91cb. Security Overview
Detected Code Changes
|
daniel-wong-dfinity-org-twin
dismissed
github-actions[bot]’s stale review
July 15, 2026 20:10
- Done.
- Everything else remains the same. Just a new method for a new feature.
- Existing data is fine.
- I seriously doubt they have time to review stuff like this now.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new governance-only Registry canister update method to manage a “standard engine” replica version rollout record (old/new version IDs plus deployment progress), and wires it into the canister interface and invariant checks.
Changes:
- Adds
update_standard_engine_replica_version(governance-only) entrypoint plus payload type to the Registry canister Candid interface. - Implements the corresponding registry mutation logic, including transition rules for progressing or starting a new deployment.
- Introduces and registers invariants for the new record and extends replica-version invariants to treat referenced versions as “in use” (must be elected).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rs/registry/canister/unreleased_changelog.md | Documents the new public Registry canister method. |
| rs/registry/canister/src/mutations/mod.rs | Exposes the new mutation module. |
| rs/registry/canister/src/mutations/do_update_standard_engine_replica_version.rs | Implements mutation logic + payload type + unit tests. |
| rs/registry/canister/src/invariants/standard_engine_replica_version.rs | Adds invariant checks for the new record + unit tests. |
| rs/registry/canister/src/invariants/replica_version.rs | Ensures versions referenced by the new record are considered “in use” (must be elected). |
| rs/registry/canister/src/invariants/mod.rs | Registers the new invariants module. |
| rs/registry/canister/src/invariants/checks.rs | Hooks the new invariant check into the global invariant pipeline. |
| rs/registry/canister/canister/registry.did | Adds payload type + service method to the public did. |
| rs/registry/canister/canister/registry_test.did | Mirrors the did changes for tests. |
| rs/registry/canister/canister/canister.rs | Adds the governance-gated canister update entrypoint and calls into the new mutation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bjoernek
approved these changes
Jul 16, 2026
Base automatically changed from
StandardEngineReplicaVersionRecord-daniel-wong
to
master
July 16, 2026 14:19
…le by Governance. Will be used in the future to implement a new proposal type.
daniel-wong-dfinity-org-twin
force-pushed
the
add-registry-method-update_standard_engine_replica_version-daniel-wong
branch
from
July 16, 2026 15:31
07d8232 to
9bf91cb
Compare
daniel-wong-dfinity-org-twin
enabled auto-merge
July 16, 2026 15:31
daniel-wong-dfinity-org-twin
removed this pull request from the merge queue due to a manual request
Jul 16, 2026
Copilot started reviewing on behalf of
daniel-wong-dfinity-org-twin
July 16, 2026 16:08
View session
daniel-wong-dfinity-org-twin
deleted the
add-registry-method-update_standard_engine_replica_version-daniel-wong
branch
July 16, 2026 16:35
This was referenced Jul 20, 2026
pull Bot
pushed a commit
to mikeyhodl/ic
that referenced
this pull request
Jul 21, 2026
When determining what replica version an engine is supposed to run (and it doesn't explicitly specify one). # Future Work Orchestrator does not use this. That will be fixed in an imminent PR. # References [👈 Previous PR][prev] | [Next PR 👉][next] [prev]: dfinity#10787 [next]: dfinity#10851 --------- Co-authored-by: Daniel Wong <daniel.wong@dfinity.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As usual, only callable by Governance. Will be used in the future to implement a new proposal type.
👈 Previous PR | Next PR 👉