Skip to content

chore(deps): remove unused ansible dependency#10837

Merged
tmu0 merged 2 commits into
masterfrom
@tmu0/bump-ansible-core
Jul 20, 2026
Merged

chore(deps): remove unused ansible dependency#10837
tmu0 merged 2 commits into
masterfrom
@tmu0/bump-ansible-core

Conversation

@tmu0

@tmu0 tmu0 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

What

Removes the ansible dependency from requirements.in and regenerates requirements.txt.

Why

ansible has no first-party consumer in this repo — no Python imports, no playbooks/roles, no scripts invoking ansible-playbook, and no Bazel target depends on it. The only remaining references are stale comments/docs. It was pulled into the dependency-scanning venv purely because it was declared here.

Effect

Dropping it also removes its exclusive transitive deps: ansible-core, jinja2, markupsafe, resolvelib (none of which are used first-party either). Net diff is a clean deletion (88 lines out of requirements.txt, nothing added).

This supersedes the earlier ansible-core version bump on this branch.

🤖 Generated with Claude Code

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python dependency lock to use ansible-core version 2.20.7 (previously 2.20.1), by adding an explicit constraint in the input requirements and regenerating the compiled, hashed requirements.txt.

Changes:

  • Added ansible-core>=2.20.7 to requirements.in to explicitly constrain the transitive dependency.
  • Regenerated requirements.txt, updating the pinned ansible-core version and its hashes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
requirements.in Adds an explicit minimum version constraint for ansible-core to drive resolution.
requirements.txt Updates the locked ansible-core version to 2.20.7 (with updated hashes / provenance comments).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Pin ansible-core explicitly in requirements.in and regenerate
requirements.txt. 2.20.7 stays within ansible 13.2.0's
`ansible-core~=2.20.1` constraint, so no other resolved versions change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@tmu0
tmu0 force-pushed the @tmu0/bump-ansible-core branch from b6f1974 to 489b0ce Compare July 20, 2026 14:59
@tmu0
tmu0 marked this pull request as ready for review July 20, 2026 15:08
@tmu0
tmu0 requested a review from a team as a code owner July 20, 2026 15:08
@tmu0
tmu0 added this pull request to the merge queue Jul 20, 2026
@basvandijk

Copy link
Copy Markdown
Collaborator

BTW @tmu0 do we still use Ansible for something?

@tmu0
tmu0 removed this pull request from the merge queue due to a manual request Jul 20, 2026
@tmu0

tmu0 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor Author

@basvandijk good point, claude doesn't find any usage. let me remove it and see if something breaks...

ansible — and its exclusive transitive deps ansible-core, jinja2,
markupsafe and resolvelib — is not referenced by any first-party code,
playbook, script or Bazel target in this repo; the only remaining
mentions are stale comments/docs. Drop it from requirements.in and
regenerate requirements.txt.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@tmu0 tmu0 changed the title chore(deps): bump ansible-core to 2.20.7 chore(deps): remove unused ansible dependency Jul 20, 2026
@tmu0
tmu0 requested a review from Copilot July 20, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@tmu0
tmu0 enabled auto-merge July 20, 2026 15:46
@tmu0
tmu0 added this pull request to the merge queue Jul 20, 2026
Merged via the queue into master with commit d35580b Jul 20, 2026
44 checks passed
@tmu0
tmu0 deleted the @tmu0/bump-ansible-core branch July 20, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants