chore(deps): bump serde_with to 3.21.0#10838
Merged
Merged
Conversation
Update serde_with from 1.14.0 to 3.21.0 in the workspace Cargo.toml and the Bazel crate spec, and repin the Cargo/Bazel lock files. This also collapses the previously duplicated transitive serde_with 3.x (pulled in via ic-bn-lib) onto a single 3.21.0, dropping the now-unused 1.x subtree (darling 0.13, strsim 0.10, serde_with_macros 1.5). The APIs in use (serde_as, DisplayFromStr, rust::double_option and serde_with::Bytes) are unchanged across the major bump, so no source changes are required. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace’s serde_with dependency to a single, consistent 3.x version across Cargo and Bazel, removing the previously duplicated 1.x subtree from the resolved dependency graph and repinning the relevant lock files.
Changes:
- Bump workspace
serde_withfrom1.14.0to3.21.0inCargo.toml. - Update Bazel Rust crate specification for
serde_withto^3.21.0. - Repin Cargo and Cargo-Bazel lock files, dropping now-unused
serde_with 1.x-related dependencies and updating associated transitive versions.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updates the workspace dependency pin for serde_with to 3.21.0. |
| Cargo.lock | Collapses to a single serde_with 3.21.0 entry and removes the obsolete 1.x subtree and related transitive deps. |
| Cargo.Bazel.toml.lock | Repins Bazel/Cargo lock data to match the new resolved dependency set (including serde_with 3.21.0). |
| Cargo.Bazel.json.lock | Repins Bazel/Cargo JSON lock data and updates resolved crate IDs/checksums for the new graph. |
| bazel/rust.MODULE.bazel | Updates the Bazel crate spec for serde_with to ^3.21.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolve lock-file conflicts from the hpke 0.13 migration (#10833) by regenerating Cargo.lock and Cargo.Bazel.{toml,json}.lock on top of the current master baseline, keeping serde_with unified at 3.21.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tmu0
marked this pull request as ready for review
July 20, 2026 15:34
tmu0
enabled auto-merge
July 20, 2026 15:34
nmattia
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
serde_withfrom1.14.0to3.21.0(workspaceCargo.toml+bazel/rust.MODULE.bazelcrate spec) and repins the lock files.Details
serde_with = "1.14.0"while a transitive3.xwas pulled in viaic-bn-lib, so the tree carried two major versions. This bump collapses both onto a single3.21.0and drops the now-unused1.xsubtree (darling 0.13,strsim 0.10,serde_with_macros 1.5) — hence the large number of deletions in the lock files.serde_as,DisplayFromStr,rust::double_option,serde_with::Bytes) are unchanged across the major bump.Verification
cargo checkpasses for the direct users (config_types,ic-types,rosetta-core).cargo clippy -D warningsclean onconfig_typesandrosetta-core.CARGO_BAZEL_REPIN) regeneratedCargo.Bazel.{toml,json}.lock;@crate_index//:serde_with(3.21.0) builds.(
config_tooland full Bazel rdeps build/test were not run locally — this host is macOS without the internal build infra, andconfig_toolhas a pre-existing Linux-only import gate. Left to CI.)🤖 Generated with Claude Code