feat(registry): Allow Cloud Engines to have blank replica_version_id (in their SubnetRecord).#10865
Merged
daniel-wong-dfinity-org-twin merged 4 commits intoJul 22, 2026
Conversation
Copilot started reviewing on behalf of
daniel-wong-dfinity-org-twin
July 22, 2026 12:53
View session
|
✅ No security or compliance issues detected. Reviewed everything up to 88e8390. Security Overview
Detected Code Changes
|
daniel-wong-dfinity-org-twin
dismissed
github-actions[bot]’s stale review
July 22, 2026 12:53
New code is not yet active in release builds. Will changelog when this feature is enabled.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates registry invariants to optionally allow CloudEngine subnets to have an empty replica_version_id in their SubnetRecord, gated behind a new (currently disabled) feature flag and the presence of a StandardEngineReplicaVersionRecord.
Changes:
- Add a new registry-canister flag for enabling blank
replica_version_idspecifically for CloudEngines. - Update replica version invariants to ignore blank
replica_version_idfor CloudEngine subnets when the flag is enabled and aStandardEngineReplicaVersionRecordexists. - Add tests covering the allowed/forbidden combinations (flag on/off, record present/absent, CloudEngine vs non-CloudEngine).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| rs/registry/canister/src/invariants/replica_version.rs | Adjusts version-in-use collection logic to permit blank CloudEngine replica_version_id under gated conditions; adds unit tests for the new behavior. |
| rs/registry/canister/src/flags.rs | Introduces a new feature flag and test-only temporary enable/disable helpers for blank CloudEngine replica_version_id. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pierugo-dfinity
approved these changes
Jul 22, 2026
pierugo-dfinity
left a comment
Contributor
There was a problem hiding this comment.
Looks great to me!
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bjoernek
approved these changes
Jul 22, 2026
daniel-wong-dfinity-org-twin
enabled auto-merge
July 22, 2026 14:45
daniel-wong-dfinity-org-twin
deleted the
allow-cloud-engines-to-have-blank-replica_version_id-daniel-wong
branch
July 22, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for that to be allowed, the following conditions must be met:
As per our standard way of doing this, this is currently DISABLED.
The plan is to enable it once all subnets (or maybe, just Cloud Engines) understand how to handle a blank
replica_version_idfield.👈 Previous PR | Next PR 👉