Skip to content

feat(governance): Enable CreateCanisterAndInstallCode proposals.#9826

Merged
daniel-wong-dfinity-org merged 2 commits intomasterfrom
enable-create-canister-and-install-code-proposals-daniel-wong
Apr 13, 2026
Merged

feat(governance): Enable CreateCanisterAndInstallCode proposals.#9826
daniel-wong-dfinity-org merged 2 commits intomasterfrom
enable-create-canister-and-install-code-proposals-daniel-wong

Conversation

@daniel-wong-dfinity-org
Copy link
Copy Markdown
Contributor

@daniel-wong-dfinity-org daniel-wong-dfinity-org commented Apr 13, 2026

References

Closes NNS1-4346.

👈 Previous PR | Next PR 👉

@daniel-wong-dfinity-org daniel-wong-dfinity-org requested a review from a team as a code owner April 13, 2026 11:16
github-actions[bot]

This comment was marked as resolved.

@github-actions github-actions Bot added the feat label Apr 13, 2026
@daniel-wong-dfinity-org daniel-wong-dfinity-org dismissed github-actions[bot]’s stale review April 13, 2026 11:19
  1. Done.
  2. Notified clients last week.
  3. Existing proposals and neurons are fine.
  4. Requested.
@daniel-wong-dfinity-org daniel-wong-dfinity-org added this pull request to the merge queue Apr 13, 2026
Merged via the queue into master with commit 086dae5 Apr 13, 2026
39 checks passed
@daniel-wong-dfinity-org daniel-wong-dfinity-org deleted the enable-create-canister-and-install-code-proposals-daniel-wong branch April 13, 2026 20:02
github-merge-queue Bot pushed a commit that referenced this pull request Apr 14, 2026
…9807)

An integration test based on PocketIc.

Outline/summary of the test:

1. Prepare the world: Create an IC with another system subnet (besides
the NNS subnet), install NNS.
2. Execute a proposal of the new type, CreateCanisterAndInstallCode.
3. Inspect the resulting canister. In particular, it should:
    1. Live in the other system subnet.
    2. Have the specified code.
    3. Be controlled by the Root canister.

# References

Closes [NNS1-4345].

[NNS1-4345]: https://dfinity.atlassian.net/browse/NNS1-4345

[👈 Previous PR][prev] | [Next PR 👉][next]

[prev]: #9789
[next]: #9826

---------

Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
daniel-wong-dfinity-org added a commit that referenced this pull request Apr 15, 2026
daniel-wong-dfinity-org added a commit that referenced this pull request Apr 15, 2026
…9807)

An integration test based on PocketIc.

Outline/summary of the test:

1. Prepare the world: Create an IC with another system subnet (besides
the NNS subnet), install NNS.
2. Execute a proposal of the new type, CreateCanisterAndInstallCode.
3. Inspect the resulting canister. In particular, it should:
    1. Live in the other system subnet.
    2. Have the specified code.
    3. Be controlled by the Root canister.

# References

Closes [NNS1-4345].

[NNS1-4345]: https://dfinity.atlassian.net/browse/NNS1-4345

[👈 Previous PR][prev] | [Next PR 👉][next]

[prev]: #9789
[next]: #9826

---------

Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants