Skip to content

chore(icrc-ledger-types): DEFI-1894: Switch icrc-ledger-types bazel variants#9900

Open
mbjorkqvist wants to merge 2 commits intomasterfrom
mathias/DEFI-1894-switch-bazel-icrc-ledger-types-storable-variants
Open

chore(icrc-ledger-types): DEFI-1894: Switch icrc-ledger-types bazel variants#9900
mbjorkqvist wants to merge 2 commits intomasterfrom
mathias/DEFI-1894-switch-bazel-icrc-ledger-types-storable-variants

Conversation

@mbjorkqvist
Copy link
Copy Markdown
Contributor

Make the default variant of icrc-ledger-types the one without the storable feature flag enabled, to make it consistent with Cargo. Update all crates depending on icrc-ledger-types to use the variant with the storable feature enabled for the reasons described in PR #7520.

@github-actions github-actions Bot added the chore label Apr 16, 2026
@mbjorkqvist mbjorkqvist marked this pull request as ready for review April 16, 2026 14:21
@mbjorkqvist mbjorkqvist requested review from a team as code owners April 16, 2026 14:21
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@mbjorkqvist mbjorkqvist dismissed github-actions[bot]’s stale review April 16, 2026 14:23
  1. No behavior changes.
  2. No breaking changes.
  3. No data migration needed.
  4. No security review needed.
Copy link
Copy Markdown
Contributor

@gregorydemay gregorydemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbjorkqvist !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants