Draft: stop handling remote DKGs in summary#9901
Draft
eichhorl wants to merge 14 commits intoeichhorl/restore-create-configs-earlyfrom
Draft
Draft: stop handling remote DKGs in summary#9901eichhorl wants to merge 14 commits intoeichhorl/restore-create-configs-earlyfrom
eichhorl wants to merge 14 commits intoeichhorl/restore-create-configs-earlyfrom
Conversation
…c into eichhorl/rm-summary-remote-dkg
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 20, 2026
…st_head_nns (#9936) ## Root cause The test `//rs/tests/consensus/orchestrator:ssh_access_to_nodes_test_head_nns` runs 16 sub-tests sequentially (through `SystemTestGroup::add_test`) after a ~2 minute `setup` phase. End-to-end the run takes roughly 14–15 minutes, which lands right at Bazel's `"long"` timeout (15 minutes / 900 seconds). I inspected the two flaky runs from the last week: * `2026-04-16T14:50:04` (master, commit `4548464`) * `2026-04-16T16:29:48` (branch `eichhorl/rm-summary-remote-dkg`, PR #9901) In **both** cases every single sub-test completed with exit code 0 and the timeout was hit right after the last sub-test (`node_keeps_keys_until_it_completely_leaves_its_subnet`) finished, while `assert_no_metrics_errors` was just starting: ``` 2026-04-16 14:50:01.401 ... Task 'node_keeps_keys_until_it_completely_leaves_its_subnet' finished with exit code: Ok(ExitStatus(unix_wait_status(0))) 2026-04-16 14:50:01.409 ... >>> assert_no_metrics_errors_fn -- Test timed out at 2026-04-16 14:50:03 UTC -- ``` So nothing is actually broken with the test logic; the suite just occasionally runs close enough to 15 min that it trips the Bazel timeout. ## Fix Bump the Bazel `test_timeout` of the `ssh_access_to_nodes_test` target from the default `"long"` (15 min) to `"eternal"` (60 min). This gives enough headroom for natural runtime variability without changing any test semantics. ## Verification Ran the test 3 times in parallel: ``` bazel test --test_output=errors --runs_per_test=3 --jobs=3 //rs/tests/consensus/orchestrator:ssh_access_to_nodes_test_head_nns ``` Result: all 3 runs passed (max 536.8s, min 503.2s, avg 514.9s). --- This PR was created following the steps in `.claude/skills/fix-flaky-tests/SKILL.md`.
Base automatically changed from
eichhorl/create-configs-early
to
eichhorl/early-remote-nidkg-2
April 23, 2026 08:20
eichhorl
changed the base branch from
eichhorl/early-remote-nidkg-2
to
eichhorl/restore-create-configs-early
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.