Generate a temporary directory for tests, instead of having it remain

Author: c8y3

src/docx_generator/docx_generator.py

@@ -40,6 +40,7 @@ def _sanitize_path(path: str) -> str:
 
 
 class DocxGenerator(object):
+
     def __init__(self, logger_mode: str = 'INFO', max_recursive_render_depth: int = 5,
                  image_handler: PictureGlobals = None, app_logger: logging = None):
 

test/component/test_docx_generator.py

@@ -20,7 +20,7 @@
 
 import os
 import re
-from pathlib import Path
+from tempfile import TemporaryDirectory
 from unittest import TestCase
 
 from docx import Document
@@ -34,7 +34,9 @@ class TestDocxGenerator(TestCase):
     def setUp(self) -> None:
         self._base_path = os.path.join(os.getcwd(), 'test/component')
         self._template_path = 'templates'
-        self._results_path = 'results'
+        self._results_directory = TemporaryDirectory(dir=self._base_path)
+        # TODO code smell, we shouldn't have to do that. This shows the generate_docx method is too complex to use
+        self._results_path = self._results_directory.name.split('/')[-1]
 
         self._output_filenames = {
             'basic_template_result': 'basic_template_result.docx',
@@ -52,16 +54,10 @@ def setUp(self) -> None:
             'unclosed_jinja_control_tag_result': 'unclosed_jinja_control_tag_result.docx'
         }
 
-        Path(self._base_path, self._results_path).mkdir(exist_ok=True)
         self._subject = DocxGenerator(logger_mode='DEBUG')
 
     def tearDown(self) -> None:
-        return None
-        for filename in self._output_filenames.values():
-            try:
-                os.remove(os.path.join(self._results_path, filename))
-            except FileNotFoundError:
-                pass
+        self._results_directory.cleanup()
 
     def test_should_generate_docx_from_basic_template(self):
         text_to_add = 'Report Name'
@@ -209,6 +205,8 @@ def test_should_not_fail_with_specific_markdown(self):
             'text_for_code_block': markdown_text2
         }
 
+        print('----------------------------------')
+        print(self._results_path)
         self._subject.generate_docx(
             self._base_path,
             os.path.join(self._template_path, 'markdown_filter_template.docx'),