Skip to content

Commit 0f1d300

Browse files
committed
Get rid of SLF4J transitive dependency #99
1 parent 5431d45 commit 0f1d300

3 files changed

Lines changed: 36 additions & 2 deletions

File tree

RELEASE-NOTES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
* #89 Deprecate redundant magics: %jars, %addMavenDependency
1919
* #90 Deprecate Ivy artifact syntax for %maven magic
2020
* #93 Extensions / kernel lifecycle
21+
* #99 Get rid of SLF4J transitive dependency
2122

2223
## 1.0-a5
2324

jjava-maven/pom.xml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2+
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
3+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
34
<modelVersion>4.0.0</modelVersion>
45

56
<parent>
@@ -33,6 +34,15 @@
3334
<groupId>org.apache.maven</groupId>
3435
<artifactId>maven-model</artifactId>
3536
</dependency>
37+
<!-- Bridging "standalone-static" loggers to JUL -->
38+
<dependency>
39+
<groupId>org.slf4j</groupId>
40+
<artifactId>slf4j-jdk14</artifactId>
41+
</dependency>
42+
<dependency>
43+
<groupId>org.slf4j</groupId>
44+
<artifactId>jcl-over-slf4j</artifactId>
45+
</dependency>
3646

3747
<!-- Test dependencies -->
3848
<dependency>

pom.xml

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,13 @@
5050
<maven.mima.version>2.4.0</maven.mima.version>
5151
<gson.version>2.11.0</gson.version>
5252
<jeromq.version>0.6.0</jeromq.version>
53+
<commons.logging.version>1.3.5</commons.logging.version>
5354

5455
<junit5.version>5.11.2</junit5.version>
5556
<hamcrest.version>1.3</hamcrest.version>
5657
<jimfs.version>1.3.0</jimfs.version>
5758
<testcontainers.version>1.21.3</testcontainers.version>
58-
<slf4j.version>1.7.36</slf4j.version>
59+
<slf4j.version>2.0.17</slf4j.version>
5960
</properties>
6061

6162
<url>https://github.com/dflib/jjava</url>
@@ -90,6 +91,13 @@
9091
<groupId>eu.maveniverse.maven.mima.runtime</groupId>
9192
<artifactId>standalone-static</artifactId>
9293
<version>${maven.mima.version}</version>
94+
<exclusions>
95+
<!-- Will add the right version of SLF4J and commons-logging bridge explicitly -->
96+
<exclusion>
97+
<groupId>org.slf4j</groupId>
98+
<artifactId>*</artifactId>
99+
</exclusion>
100+
</exclusions>
93101
</dependency>
94102
<dependency>
95103
<groupId>eu.maveniverse.maven.mima.extensions</groupId>
@@ -136,6 +144,21 @@
136144
<artifactId>testcontainers</artifactId>
137145
<version>${testcontainers.version}</version>
138146
</dependency>
147+
<dependency>
148+
<groupId>org.slf4j</groupId>
149+
<artifactId>slf4j-api</artifactId>
150+
<version>${slf4j.version}</version>
151+
</dependency>
152+
<dependency>
153+
<groupId>org.slf4j</groupId>
154+
<artifactId>slf4j-jdk14</artifactId>
155+
<version>${slf4j.version}</version>
156+
</dependency>
157+
<dependency>
158+
<groupId>org.slf4j</groupId>
159+
<artifactId>jcl-over-slf4j</artifactId>
160+
<version>${slf4j.version}</version>
161+
</dependency>
139162
<dependency>
140163
<groupId>org.slf4j</groupId>
141164
<artifactId>slf4j-simple</artifactId>

0 commit comments

Comments
 (0)