Skip to content

Commit 3843312

Browse files
committed
Get rid of SLF4J transitive dependency #99
* only binding JUL logger in the distro. The rest of the stack should stay SLF4J-focused.
1 parent 0f1d300 commit 3843312

2 files changed

Lines changed: 8 additions & 11 deletions

File tree

jjava-distro/pom.xml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@
2828
<artifactId>jjava-launcher</artifactId>
2929
<version>${project.version}</version>
3030
</dependency>
31+
<!-- A few upstream libraries using SLF4J should be routed to JUL in the final kernel -->
32+
<dependency>
33+
<groupId>org.slf4j</groupId>
34+
<artifactId>slf4j-jdk14</artifactId>
35+
</dependency>
3136

3237
<!-- Test dependencies -->
3338
<dependency>
@@ -40,11 +45,6 @@
4045
<artifactId>testcontainers</artifactId>
4146
<scope>test</scope>
4247
</dependency>
43-
<dependency>
44-
<groupId>org.slf4j</groupId>
45-
<artifactId>slf4j-simple</artifactId>
46-
<scope>test</scope>
47-
</dependency>
4848
</dependencies>
4949

5050
<build>
@@ -138,7 +138,8 @@
138138
<Main-Class>org.dflib.jjava.distro.JJava</Main-Class>
139139
</manifestEntries>
140140
</transformer>
141-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
141+
<transformer
142+
implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
142143
</transformers>
143144
</configuration>
144145
</plugin>

jjava-maven/pom.xml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,7 @@
3434
<groupId>org.apache.maven</groupId>
3535
<artifactId>maven-model</artifactId>
3636
</dependency>
37-
<!-- Bridging "standalone-static" loggers to JUL -->
38-
<dependency>
39-
<groupId>org.slf4j</groupId>
40-
<artifactId>slf4j-jdk14</artifactId>
41-
</dependency>
37+
<!-- Explicitly control the version of SLF4J used by "standalone-static" loggers -->
4238
<dependency>
4339
<groupId>org.slf4j</groupId>
4440
<artifactId>jcl-over-slf4j</artifactId>

0 commit comments

Comments
 (0)