Deprecate Ivy artifact syntax for %maven magic #90

Author: andrus

RELEASE-NOTES.md

@@ -14,6 +14,7 @@
 - #84 Refactoring: reorg Maven modules for reusability
 - #86 ineffecient / incorrect classpath handling
 - #89 Deprecate redundant magics: %jars, %addMavenDependency
+- #90 Deprecate Ivy artifact syntax for %maven magic
 
 ## 1.0-a5
 

jjava-distro/src/test/java/org/dflib/jjava/distro/KernelMagicIT.java

@@ -57,8 +57,9 @@ public void maven() throws Exception {
         assertThat(snippetResult.getStdout(), containsString("dflib-jupyter-1.0.0-RC1.jar"));
     }
 
+    @Deprecated
     @Test
-    public void addIvyDependency() throws Exception {
+    public void mavenIvySyntax() throws Exception {
         String snippet = String.join("\n",
                 "%maven jakarta.annotation#jakarta.annotation-api;3.0.0",
                 "System.getProperty(\"java.class.path\")"

jjava-maven/src/main/java/org/dfllib/jjava/maven/MavenDependencyResolver.java

@@ -39,6 +39,7 @@ public class MavenDependencyResolver {
     /**
      * Ivy artifact coordinates in the form organization#name[#branch];revision.
      */
+    @Deprecated(since = "1.0", forRemoval = true)
     private static final Pattern IVY_MRID_PATTERN = Pattern.compile(
             "^(?<organization>[-\\w/._+=]*)#(?<name>[-\\w/._+=]+)(?:#(?<branch>[-\\w/._+=]+))?;(?<revision>[-\\w/._+=,\\[\\]{}():@]+)$"
     );
@@ -49,13 +50,20 @@ private static RemoteRepository mavenRepo(String id, String url) {
 
     private static Artifact parseArtifact(String coordinates) {
         Matcher ivyMatcher = IVY_MRID_PATTERN.matcher(coordinates);
-        if (ivyMatcher.matches()) {
-            String organization = ivyMatcher.group("organization");
-            String name = ivyMatcher.group("name");
-            String revision = ivyMatcher.group("revision");
-            return new DefaultArtifact(organization, name, "jar", revision);
-        }
-        return new DefaultArtifact(coordinates);
+        return ivyMatcher.matches() ? parseIvyArtifact(ivyMatcher, coordinates) : new DefaultArtifact(coordinates);
+    }
+
+    @Deprecated(since = "1.0", forRemoval = true)
+    private static Artifact parseIvyArtifact(Matcher matcher, String coordinates) {
+        System.err.println("Detected Ivy artifact syntax in the '%maven' magic arguments: '"
+                + coordinates
+                + "'. Support for it is deprecated and will be removed in the future versions of JJava. "
+                + "Use Maven colon-separated syntax instead");
+
+        String organization = matcher.group("organization");
+        String name = matcher.group("name");
+        String revision = matcher.group("revision");
+        return new DefaultArtifact(organization, name, "jar", revision);
     }
 
     private final List<RemoteRepository> repositories;