Skip to content

Commit 83ac3a6

Browse files
committed
Extension loading from classpath #71
minor cleanup, removing obsolete comments
1 parent ef44c0b commit 83ac3a6

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

jjava-kernel/src/test/java/org/dflib/jjava/kernel/ExtensionsLifecycleTest.java renamed to jjava-kernel/src/test/java/org/dflib/jjava/kernel/JavaKernelExtensionsLifecycleTest.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@
88
import static org.junit.jupiter.api.Assertions.*;
99
import static org.junit.jupiter.api.Assertions.assertEquals;
1010

11-
// TODO: move this to BaseKernel? There's nothing JavaKernel specific here
12-
public class ExtensionsLifecycleTest {
11+
public class JavaKernelExtensionsLifecycleTest {
1312

1413
@Test
1514
public void defaultExtensions() {
@@ -38,8 +37,7 @@ void extraClasspathExtensions() throws Exception {
3837

3938
String extraClasspath = PathsHandler.joinPaths(PathsHandler.resolveGlobs(jar.toAbsolutePath().toString()));
4039

41-
String extensionClassName = "org.dflib.jjava.kernel.test.TestExtension";
42-
String extInstalledProp = extensionInstallationsProperty(extensionClassName);
40+
String extInstalledProp = "ext.installs:org.dflib.jjava.kernel.test.TestExtension";
4341
System.clearProperty(extInstalledProp);
4442

4543
JavaKernel kernel = JavaKernel
@@ -64,7 +62,4 @@ void extraClasspathExtensions() throws Exception {
6462
assertNull(System.getProperty(extInstalledProp));
6563
}
6664

67-
private static String extensionInstallationsProperty(String className) {
68-
return "ext.installs:" + className;
69-
}
7065
}

0 commit comments

Comments
 (0)