Env refactor Phase 3 cleanup: fix CI and harden runtime env loading#255

Merged

dfrysinger merged 84 commits into

mainfrom

copilot/featureenv-refactor-cleanup

Mar 24, 2026

Commits on Mar 5, 2026

fix: widen test grep window for safe-mode marker removal check (M1)
Claude (Habitat-1)
committed
feat: post-merge robustness analysis + systemd/security linter
Claude (Habitat-1)
committed

Commits on Mar 6, 2026

docs: add Phase 0 robustness quick wins to ENV-REFACTOR-PLAN
Claude (Habitat-1)
committed
docs: address all ChatGPT inline review comments in ENV-REFACTOR-PLAN
Claude (Habitat-1)
committed
feat: Phase 0 robustness — config validation, delivery verify, env contract
Claude (Habitat-1)
committed
fix: address Phase 0 code review observations
Claude (Habitat-1)
committed

Commits on Mar 8, 2026

Commits on Mar 9, 2026

Commits on Mar 10, 2026

Commits on Mar 11, 2026

fix: fail fast on invalid env parsing

Copilot
and
dfrysinger
committed

Commits on Mar 19, 2026

fix: replace silent failure patterns with logged warnings

dfrysinger
and
claude
committed
fix: replace silent failures in gateway-health-check.sh with logged warnings

dfrysinger
and
claude
committed
fix: gate VALIDATE_*_FN overrides behind TEST_MODE, log emergency config stderr

dfrysinger
and
claude
committed
fix: warn on unknown platform values in parse-habitat.py

dfrysinger
and
claude
committed
fix: log setup_safe_mode_workspace failure instead of swallowing it

dfrysinger
and
claude
committed
fix: warn when habitat-parsed.env missing during default group.env generation

dfrysinger
and
claude
committed
fix: propagate check_agents_e2e exit code instead of swallowing with || true

dfrysinger
and
claude
committed
fix: gate VALIDATE_API_KEY_FN behind TEST_MODE (security hardening)

dfrysinger
and
claude
committed
fix: warn when habitat-parsed.env missing in generate_group_env (isolated mode)

dfrysinger
and
claude
committed
fix: use agent1 account key instead of default in phase1-critical.sh

dfrysinger
and
claude
committed
fix: env contract test uses assert instead of warnings.warn, rename misleading test

dfrysinger
and
claude
committed
fix: remove dead check_api_connectivity, add unknown platform warning, fix call site arg

dfrysinger
and
claude
committed
fix: quote secret values in default group.env heredoc

dfrysinger
and
claude
committed
fix: quote secrets in heredoc, restore exit 0 on env load failure, remove redundant port fetch

authored and
Daniel Frysinger
committed
fix: restore single-agent reply_acct default, validate account key mismatch, decode OPENAI key, escape quoted secrets

authored and
Daniel Frysinger
committed
Fix 3 failing local test suites

authored and
Daniel Frysinger
committed
fix: bump Node download from 22.12.0 to 22.16.0

authored and
Daniel Frysinger
committed
fix: parameterize hatchery-version and support copilot/* branches

authored and
Daniel Frysinger
committed

Commits on Mar 20, 2026

fix: extract semver from openclaw --version for Docker build

authored and
Daniel Frysinger
committed
fix: pre-create volume mount dirs before docker compose starts

authored and
Daniel Frysinger
committed
fix: increase container health check start_period and systemd timeout for cold boot

authored and
Daniel Frysinger
committed
fix: set NODE_OPTIONS heap size in container to prevent V8 OOM crash

authored and
Daniel Frysinger
committed
fix(verify-2c): use docker kill SIGKILL for restart-on-failure test

authored and
Daniel Frysinger
committed
fix: compute NODE_OPTIONS heap size from container mem_limit to prevent V8 OOM

authored and
Daniel Frysinger
committed
fix: disable sshd reverse DNS lookup to prevent banner exchange hangs

authored and
Daniel Frysinger
committed
fix: remove memswap_limit to allow swap headroom for containers

authored and
Daniel Frysinger
committed

Commits on Mar 21, 2026

fix: resolve container safe mode test failures

authored and
Daniel Frysinger
committed
revert: broken-grp memory back to 512m for faster safe-mode trigger

authored and
Daniel Frysinger
committed
fix: remove check_agents_e2e reference from send_agent_intros comment

authored and
Daniel Frysinger
committed
fix: single-quote secrets in group.env for round-trip safety

authored and
Daniel Frysinger
committed
fix: harden error handling in gateway-health-check.sh

authored and
Daniel Frysinger
committed
fix: harden group.env generation error handling and permissions

authored and
Daniel Frysinger
committed
fix: add defensive warning for embedded single quotes in env_load_file_safe

authored and
Daniel Frysinger
committed
fix: round 2 error handling in gateway-health-check.sh

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix: container ExecStartPost env vars, parse-habitat error handling, model key fallbacks

authored and
Daniel Frysinger
committed
docs: fix stale comments and update ENV-REFACTOR-PLAN.md

authored and
Daniel Frysinger
committed
fix: capture API key check exit code before negation

authored and
Daniel Frysinger
committed

Commits on Mar 22, 2026

fix(verify-2c): reset restart counter and increase wait for kill test

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix(isolation): filter per-agent tokens by group in group.env

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix(e2e): retry agent check 3x with 60s timeout for cold-boot latency

Daniel Frysinger
authored and
Daniel Frysinger
committed

Commits on Mar 23, 2026

fix(verify-2c): use docker exec kill to simulate crash instead of docker kill

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix(verify-2c): test stop+restart instead of kill (Docker ignores restart policy on external kill)

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix(verify-2c): poll for healthy status instead of fixed 30s sleep

Daniel Frysinger
authored and
Daniel Frysinger
committed
fix(verify): wait for services to finish ExecStartPost before checking status

Daniel Frysinger
authored and
Daniel Frysinger
committed

Commits on Mar 24, 2026

fix(tests): update tests for env refactor changes

authored and
Daniel Frysinger
committed