Skip to content

Commit 9a3ec33

Browse files
committed
added PHP 8 typehints
1 parent bddcee2 commit 9a3ec33

28 files changed

Lines changed: 72 additions & 108 deletions

src/Dibi/Bridges/Tracy/Panel.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class Panel implements Tracy\IBarPanel
3232
private array $events = [];
3333

3434

35-
public function __construct($explain = true, ?int $filter = null)
35+
public function __construct(bool $explain = true, ?int $filter = null)
3636
{
3737
$this->filter = $filter ?: Event::QUERY;
3838
$this->explain = $explain;

src/Dibi/Connection.php

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -187,9 +187,8 @@ final public function isConnected(): bool
187187
/**
188188
* Returns configuration variable. If no $key is passed, returns the entire array.
189189
* @see self::__construct
190-
* @return mixed
191190
*/
192-
final public function getConfig(?string $key = null, $default = null)
191+
final public function getConfig(?string $key = null, $default = null): mixed
193192
{
194193
return $key === null
195194
? $this->config
@@ -212,21 +211,19 @@ final public function getDriver(): Driver
212211

213212
/**
214213
* Generates (translates) and executes SQL query.
215-
* @param mixed ...$args
216214
* @throws Exception
217215
*/
218-
final public function query(...$args): Result
216+
final public function query(mixed ...$args): Result
219217
{
220218
return $this->nativeQuery($this->translate(...$args));
221219
}
222220

223221

224222
/**
225223
* Generates SQL query.
226-
* @param mixed ...$args
227224
* @throws Exception
228225
*/
229-
final public function translate(...$args): string
226+
final public function translate(mixed ...$args): string
230227
{
231228
if (!$this->driver) {
232229
$this->connect();
@@ -238,9 +235,8 @@ final public function translate(...$args): string
238235

239236
/**
240237
* Generates and prints SQL query.
241-
* @param mixed ...$args
242238
*/
243-
final public function test(...$args): bool
239+
final public function test(mixed ...$args): bool
244240
{
245241
try {
246242
Helpers::dump($this->translate(...$args));
@@ -260,10 +256,9 @@ final public function test(...$args): bool
260256

261257
/**
262258
* Generates (translates) and returns SQL query as DataSource.
263-
* @param mixed ...$args
264259
* @throws Exception
265260
*/
266-
final public function dataSource(...$args): DataSource
261+
final public function dataSource(mixed ...$args): DataSource
267262
{
268263
return new DataSource($this->translate(...$args), $this);
269264
}
@@ -426,10 +421,7 @@ public function rollback(?string $savepoint = null): void
426421
}
427422

428423

429-
/**
430-
* @return mixed
431-
*/
432-
public function transaction(callable $callback)
424+
public function transaction(callable $callback): mixed
433425
{
434426
if ($this->transactionDepth === 0) {
435427
$this->begin();
@@ -535,45 +527,40 @@ public function substitute(string $value): string
535527

536528
/**
537529
* Executes SQL query and fetch result - shortcut for query() & fetch().
538-
* @param mixed ...$args
539530
* @throws Exception
540531
*/
541-
public function fetch(...$args): ?Row
532+
public function fetch(mixed ...$args): ?Row
542533
{
543534
return $this->query($args)->fetch();
544535
}
545536

546537

547538
/**
548539
* Executes SQL query and fetch results - shortcut for query() & fetchAll().
549-
* @param mixed ...$args
550540
* @return Row[]|array[]
551541
* @throws Exception
552542
*/
553-
public function fetchAll(...$args): array
543+
public function fetchAll(mixed ...$args): array
554544
{
555545
return $this->query($args)->fetchAll();
556546
}
557547

558548

559549
/**
560550
* Executes SQL query and fetch first column - shortcut for query() & fetchSingle().
561-
* @param mixed ...$args
562-
* @return mixed
563551
* @throws Exception
564552
*/
565-
public function fetchSingle(...$args)
553+
public function fetchSingle(mixed ...$args): mixed
566554
{
567555
return $this->query($args)->fetchSingle();
568556
}
569557

570558

571559
/**
572560
* Executes SQL query and fetch pairs - shortcut for query() & fetchPairs().
573-
* @param mixed ...$args
574561
* @throws Exception
575562
*/
576-
public function fetchPairs(...$args): array
563+
public function fetchPairs(mixed ...$args): array
577564
{
578565
return $this->query($args)->fetchPairs();
579566
}

src/Dibi/DataSource.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function __construct(string $sql, Connection $connection)
5555
* @param string|array $col column name or array of column names
5656
* @param string $as column alias
5757
*/
58-
public function select($col, ?string $as = null): self
58+
public function select(string|array $col, ?string $as = null): static
5959
{
6060
if (is_array($col)) {
6161
$this->cols = $col;
@@ -71,7 +71,7 @@ public function select($col, ?string $as = null): self
7171
/**
7272
* Adds conditions to query.
7373
*/
74-
public function where($cond): self
74+
public function where($cond): static
7575
{
7676
$this->conds[] = is_array($cond)
7777
? $cond // TODO: not consistent with select and orderBy
@@ -85,7 +85,7 @@ public function where($cond): self
8585
* Selects columns to order by.
8686
* @param string|array $row column name or array of column names
8787
*/
88-
public function orderBy($row, string $direction = 'ASC'): self
88+
public function orderBy(string|array $row, string $direction = 'ASC'): static
8989
{
9090
if (is_array($row)) {
9191
$this->sorting = $row;
@@ -101,7 +101,7 @@ public function orderBy($row, string $direction = 'ASC'): self
101101
/**
102102
* Limits number of rows.
103103
*/
104-
public function applyLimit(int $limit, ?int $offset = null): self
104+
public function applyLimit(int $limit, ?int $offset = null): static
105105
{
106106
$this->limit = $limit;
107107
$this->offset = $offset;
@@ -151,7 +151,7 @@ public function fetch(): ?Row
151151
* Like fetch(), but returns only first field.
152152
* @return mixed value on success, null if no next record
153153
*/
154-
public function fetchSingle()
154+
public function fetchSingle(): mixed
155155
{
156156
return $this->getResult()->fetchSingle();
157157
}

src/Dibi/DateTime.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ class DateTime extends \DateTimeImmutable
1717
{
1818
use Strict;
1919

20-
/**
21-
* @param string|int $time
22-
*/
23-
public function __construct($time = 'now', ?\DateTimeZone $timezone = null)
20+
public function __construct(string|int $time = 'now', ?\DateTimeZone $timezone = null)
2421
{
2522
$timezone = $timezone ?: new \DateTimeZone(date_default_timezone_get());
2623
if (is_numeric($time)) {

src/Dibi/Drivers/DummyDriver.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function rollback(?string $savepoint = null): void
5757
}
5858

5959

60-
public function getResource()
60+
public function getResource(): mixed
6161
{
6262
return null;
6363
}
@@ -171,8 +171,9 @@ public function free(): void
171171
}
172172

173173

174-
public function getResultResource()
174+
public function getResultResource(): mixed
175175
{
176+
return null;
176177
}
177178

178179

src/Dibi/Drivers/FirebirdDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public function inTransaction(): bool
190190
* Returns the connection resource.
191191
* @return resource|null
192192
*/
193-
public function getResource()
193+
public function getResource(): mixed
194194
{
195195
return is_resource($this->connection) ? $this->connection : null;
196196
}

src/Dibi/Drivers/FirebirdResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public function free(): void
102102
* Returns the result set resource.
103103
* @return resource|null
104104
*/
105-
public function getResultResource()
105+
public function getResultResource(): mixed
106106
{
107107
$this->autoFree = false;
108108
return is_resource($this->resultSet) ? $this->resultSet : null;

src/Dibi/Drivers/MySqliDriver.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,7 @@ public function query(string $sql): ?Dibi\ResultDriver
158158
}
159159

160160

161-
/**
162-
* @param int|string $code
163-
*/
164-
public static function createException(string $message, $code, string $sql): Dibi\DriverException
161+
public static function createException(string $message, int|string $code, string $sql): Dibi\DriverException
165162
{
166163
if (in_array($code, [1216, 1217, 1451, 1452, 1701], true)) {
167164
return new Dibi\ForeignKeyConstraintViolationException($message, $code, $sql);

src/Dibi/Drivers/NoDataResult.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public function getResultColumns(): array
6060
}
6161

6262

63-
public function getResultResource()
63+
public function getResultResource(): mixed
6464
{
6565
return null;
6666
}

src/Dibi/Drivers/OdbcDriver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ public function inTransaction(): bool
170170
* Returns the connection resource.
171171
* @return resource|null
172172
*/
173-
public function getResource()
173+
public function getResource(): mixed
174174
{
175175
return is_resource($this->connection) ? $this->connection : null;
176176
}

0 commit comments

Comments
 (0)