Merge branch 'main' into builder-for-iterator-options

Author: Naelpuissant

.github/workflows/cd-badger.yml

@@ -9,7 +9,7 @@ on:
         type: string
 
 permissions:
-  contents: read
+  contents: write
 
 jobs:
   badger-build-amd64:
@@ -95,3 +95,25 @@ jobs:
           path: |
             badger/badger-checksum-linux-arm64.sha256
             badger/badger-linux-arm64.tar.gz
+
+  upload-to-release:
+    runs-on: ubuntu-latest
+    needs: [badger-build-amd64, badger-build-arm64]
+    steps:
+      - name: Download all build artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: artifacts
+          merge-multiple: true
+      - name: List downloaded artifacts
+        run: ls -alR artifacts/
+      - name: Upload assets to GitHub Release
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          gh release upload "${{ github.event.inputs.releasetag }}" \
+            artifacts/badger-linux-amd64.tar.gz \
+            artifacts/badger-checksum-linux-amd64.sha256 \
+            artifacts/badger-linux-arm64.tar.gz \
+            artifacts/badger-checksum-linux-arm64.sha256 \
+            --repo "${{ github.repository }}"

.trunk/trunk.yaml

@@ -22,7 +22,7 @@ lint:
         - pb/*.pb.go
   enabled:
     - golangci-lint2@2.4.0
-    - trivy@0.64.1
+    - trivy@0.69.3
     - renovate@41.76.0
     - actionlint@1.7.7
     - checkov@3.2.461

db.go

@@ -671,6 +671,11 @@ const (
 // Sync syncs database content to disk. This function provides
 // more control to user to sync data whenever required.
 func (db *DB) Sync() error {
+	if db.opt.InMemory {
+		// InMemory mode does not use WAL/vlog files, so Sync is a no-op.
+		return nil
+	}
+
 	/**
 	Make an attempt to sync both the logs, the active memtable's WAL and the vLog (1847).
 	Cases:

db_test.go

@@ -2161,6 +2161,19 @@ func TestSyncForReadingTheEntriesThatWereSynced(t *testing.T) {
 	}
 }
 
+func TestSyncInMemoryNoError(t *testing.T) {
+	opt := getTestOptions("")
+	opt.InMemory = true
+
+	runBadgerTest(t, &opt, func(t *testing.T, db *DB) {
+		err := db.Update(func(txn *Txn) error {
+			return txn.Set([]byte("key"), []byte("value"))
+		})
+		require.NoError(t, err)
+		require.NoError(t, db.Sync())
+	})
+}
+
 func TestForceFlushMemtable(t *testing.T) {
 	dir, err := os.MkdirTemp("", "badger-test")
 	require.NoError(t, err, "temp dir for badger could not be created")