Skip to content

perf(table): remove defer/recover from blockIterator.setIdx #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shaunpatterson wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −12
Open

perf(table): remove defer/recover from blockIterator.setIdx #2279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions table/iterator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ package table

import (
"bytes"
"fmt"
"io"
"sort"

Expand Down Expand Up @@ -75,17 +74,6 @@ func (itr *blockIterator) setIdx(i int) {
// EndOffset of the current entry is the start offset of the next entry.
endOffset = int(itr.entryOffsets[itr.idx+1])
}
defer func() {
if r := recover(); r != nil {
var debugBuf bytes.Buffer
fmt.Fprintf(&debugBuf, "==== Recovered====\n")
fmt.Fprintf(&debugBuf, "Table ID: %d\nBlock ID: %d\nEntry Idx: %d\nData len: %d\n"+
"StartOffset: %d\nEndOffset: %d\nEntryOffsets len: %d\nEntryOffsets: %v\n",
itr.tableID, itr.blockID, itr.idx, len(itr.data), startOffset, endOffset,
len(itr.entryOffsets), itr.entryOffsets)
panic(debugBuf.String())
}
}()

entryData := itr.data[startOffset:endOffset]
var h header
Expand Down