fix(in-memory): resolve orphaned skiplist arena leak on Close#2295
Open
parthbhanti22 wants to merge 1 commit into
Open
fix(in-memory): resolve orphaned skiplist arena leak on Close#2295parthbhanti22 wants to merge 1 commit into
parthbhanti22 wants to merge 1 commit into
Conversation
Signed-off-by: Parth Bhanti <parthbhanti22@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2205.
Root Cause:
When Badger is configured with
opt.InMemory = true, thedb.close()function triggers an early return. This prevents the cleanup logic from iterating over the immutable memtables slice (db.imm). Becausemmapallocations bypass Go's GC, failing to explicitly callDecrRef()on these memtables leaves theskl.Arenaallocations orphaned in memory indefinitely.The Fix:
Added an explicit iteration over
db.immto decrement reference counts on all immutable memtables prior to the early return in the in-memory shutdown sequence.Verification:
Included
issue_2205_test.goto aggressively cycle in-memory database instantiation.pprofinuse_spaceshowed ~83GB of retainedskl.newArenaallocations across 1000 iterations.All tests in
./test.shpass locally.Checklist