fix(core): delete existing plists when doing a single UID update#9375
Closed
xqqp wants to merge 1 commit into
Closed
fix(core): delete existing plists when doing a single UID update#9375xqqp wants to merge 1 commit into
xqqp wants to merge 1 commit into
Conversation
xqqp
force-pushed
the
fix_singleUidUpdate
branch
from
660e5a9 to
d88bef5
Compare
xqqp
changed the title
|
Hey, thanks a lot for your diff. You saved me precious time trying to track down which change caused the issue. The reason I removed it in first place was that I thought iterate() would fix it. But I guess there were some corner cases. A simple fix was you could just iterate on m.startTs - 1. I checked, it's also passing all the tests. However we are going a different direction. I don't to keep thinking about the corner cases, we are just simply going to use deleteAll to delete all the old values fixing the issue. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a single UID predicate (not a list) is updated, the old value is not deleted. This bug was introduced in #9292.
This PR adds the old behavior back.
Related: https://discuss.hypermode.com/t/inconsistent-query-result/19844/7
Note: I don't know why this was changed in the original PR as the existing comment in the code says that the loop is necessary, so please review carefully.