fix(backup): prevent duplicate predicates in backup manifest for vector indexes#9679
Merged
matthewmcneely merged 2 commits intomainfrom Apr 8, 2026
Merged
fix(backup): prevent duplicate predicates in backup manifest for vector indexes#9679matthewmcneely merged 2 commits intomainfrom
matthewmcneely merged 2 commits intomainfrom
Conversation
matthewmcneely
requested changes
Apr 7, 2026
Contributor
matthewmcneely
left a comment
There was a problem hiding this comment.
Looks good but there's no test covering the scenario where a group has multiple vector predicates with indexes. A test should:
- Create a schema with 2+ float32vector predicates with HNSW indexes in the same group
- Run ProcessBackupRequest
- Verify the backup request's Predicates list includes the supporting predicates (VecEntry, VecKeyword, VecDead) for all vector predicates, not just the last one
Without such a test, this exact bug pattern (appending to the wrong map key) could easily regress.
added 2 commits
April 8, 2026 17:23
b17813d to
98ba3e1
Compare
matthewmcneely
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug in ProcessBackupRequest where vecPredMap[gid] was being built using predMap[gid] as the append base instead of vecPredMap[gid]. This caused all base predicates in the group to be duplicated in the manifest every time a vector predicate was found, making manifest.json grow larger and larger with each backup.
With multiple vector predicates in the same group, each iteration also overwrote the previous result, so only the last vector predicate's supporting entries (__vector_entry, _vector, __vector_dead) were kept the rest were silently lost.