fix: .gitignore the real test-log path (changedetectionio/tests/logs)#4247
Open
AmirF194 wants to merge 1 commit into
Open
fix: .gitignore the real test-log path (changedetectionio/tests/logs)#4247AmirF194 wants to merge 1 commit into
AmirF194 wants to merge 1 commit into
Conversation
The test harness (changedetectionio/tests/conftest.py) writes per-test loguru logs to $(dirname __file__)/logs = changedetectionio/tests/logs/. .gitignore only had 'tests/logs/', which git anchors to the repo root; there is no repo-root tests/, so the rule matched nothing and every local test run left ~200 untracked *_master.log files in the working tree. Point the pattern at the real path so the logs are ignored as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running the test suite locally leaves ~200 untracked
*_master.logfiles in the working tree —git statusreports the wholechangedetectionio/tests/logs/directory as untracked after any localpytestrun.changedetectionio/tests/conftest.pywrites a per-test loguru log to:.gitignorealready intends to ignore these (tests/logs/), but because that pattern contains a slash, git anchors it to the repo root. There is no repo-roottests/, so the rule matches nothing:Fix
Point the pattern at the path the harness actually writes to,
changedetectionio/tests/logs/, and add a comment noting where it comes from..gitignore-only; no code/behavior change.Verification
The directory is now correctly ignored, and a fresh test run no longer dirties the working tree.