diff-hl-show-hunk-inline: Put underline at descent line#290
Merged
Conversation
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the inline popups display the top border (drawn using
:underlineon the header line) slightly too high. This is because Emacs draws underlines at the baseline unlessx-underline-at-descent-lineis enabled, but that setting affects Emacs globally. Since Emacs 29, the:underlineattribute accepts the property:position, which specifies where the underline should be drawn. If it is non-nil, then the underline is displayed at the descent of the text instead of the baseline. I've made a tiny change to enable that property for underlines in diff-hl when Emacs 29+ is detected. I've included two screenshots below showing the difference. Notice that the bottom border is unaffected, because it's an overline.Before:
After: